-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding opengraph support to markdown frontmatter #295
Comments
I believe we should have support to override most of this baked in already.
@Pete-Robelou, can you please confirm? Perhaps something to document in the README? |
@adamduncan I can confirm you are correct, all these values can be overriden with frontmatter as you have stated. We have multiple README files through out the site to specifically address blog posts, case studies etc... as they all have different content requirements; however, as |
@Thingee Looks like you've done the right thing here by ensuring there's a relative @Pete-Robelou The issue here might be relative URLs. The <meta property="og:image" content="{% if image %}{{ site.url }}{{ page.url }}{{ image }}{% else %}{{ site.url }}/assets/favicons/logo-meta-share.png{% endif %}"/>
...
<meta property="twitter:image" content="{% if image %}{{ site.url }}{{ page.url }}{{ image }}{% else %}{{ site.url }}/assets/favicons/logo-meta-share.png{% endif %}"/> |
@adamduncan Yeah, you're right. If we make the meta tag image URLs absolute that should resolve the issue. Your code snippet should work and just needs to replace the relevant lines in |
It would be useful to be able to specify an opengraph title (and maybe even image link) to markdown frontmatter, to provide control over the title. Right now everything seems to pull from https://github.com/ceph/ceph.io/blob/main/src/src.json#L6:
The text was updated successfully, but these errors were encountered: