Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: enable stale bot for PRs #914

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

Enable stale bot to mark PRs stale and eventually close stale PRs. I had tried to manually do this in the past with nice comments but I forget to do it and trying to be nice was unrewarding. I find a bunch of old PRs in the list a distraction and don't want to have to think about them or try to follow up on them. I want to be generous to PR authors so PRs can be inactive for 60 days and one has 3 weeks to unstale the PR.

Workflows only change.

@phlogistonjohn
Copy link
Collaborator Author

I'm initially leaving off the no-API label to give this a little bit of opportunity for extra discussion (if needed). I'm happy to discuss either the overall intent or just argue about the timings ;-)

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm initially leaving off the no-API label to give this a little bit of opportunity for extra discussion (if needed). I'm happy to discuss either the overall intent or just argue about the timings ;-)

I'm fine with a reduced time period of 2 weeks before pull request gets closed post stale notification.

.github/workflows/stale.yml Show resolved Hide resolved
@phlogistonjohn
Copy link
Collaborator Author

phlogistonjohn commented Aug 17, 2023

I'm fine with a reduced time period of 2 weeks before pull request gets closed post stale notification.

My rationale behind three weeks was that many people take two-week vacations but 3 weeks is much rarer.

How about adding a message while closing the pull request using close-pr-message?

OK, how about:

This Pull Request has been automatically closed due to
inactivity. In the future, if you resume working on this 
again, the PR can be reopened. Additionally, if you are
proposing a feature or fix that you think someone else
could take up - please say so - and if there isn't one
already, file an issue for the topic. Thank you for
your contribution.

Enable stale bot to mark PRs stale and eventually close stale PRs. I had
tried to manually do this in the past with nice comments but I forget
to do it and trying to be nice was unrewarding. I find a bunch of old
PRs in the list a distraction and don't want to have to think about them
or try to follow up on them. I want to be generous to PR authors so PRs
can be inactive for 60 days and one has 3 weeks to unstale the PR.

Signed-off-by: John Mulligan <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with a reduced time period of 2 weeks before pull request gets closed post stale notification.

My rationale behind three weeks was that many people take two-week vacations but 3 weeks is much rarer.

Ok.

How about adding a message while closing the pull request using close-pr-message?

OK, how about:

This Pull Request has been automatically closed due to
inactivity. In the future, if you resume working on this 
again, the PR can be reopened. Additionally, if you are
proposing a feature or fix that you think someone else
could take up - please say so - and if there isn't one
already, file an issue for the topic. Thank you for
your contribution.

lgtm, thanks.

Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Aug 22, 2023
@mergify mergify bot merged commit 5afbdd6 into ceph:master Aug 22, 2023
15 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-stale-prs branch August 23, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants