-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: enable stale bot for PRs #914
Conversation
I'm initially leaving off the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm initially leaving off the no-API label to give this a little bit of opportunity for extra discussion (if needed). I'm happy to discuss either the overall intent or just argue about the timings ;-)
I'm fine with a reduced time period of 2 weeks before pull request gets closed post stale notification.
My rationale behind three weeks was that many people take two-week vacations but 3 weeks is much rarer.
OK, how about:
|
9ff4b1a
to
4c4dd87
Compare
Enable stale bot to mark PRs stale and eventually close stale PRs. I had tried to manually do this in the past with nice comments but I forget to do it and trying to be nice was unrewarding. I find a bunch of old PRs in the list a distraction and don't want to have to think about them or try to follow up on them. I want to be generous to PR authors so PRs can be inactive for 60 days and one has 3 weeks to unstale the PR. Signed-off-by: John Mulligan <[email protected]>
4c4dd87
to
a6d5547
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with a reduced time period of 2 weeks before pull request gets closed post stale notification.
My rationale behind three weeks was that many people take two-week vacations but 3 weeks is much rarer.
Ok.
How about adding a message while closing the pull request using close-pr-message?
OK, how about:
This Pull Request has been automatically closed due to inactivity. In the future, if you resume working on this again, the PR can be reopened. Additionally, if you are proposing a feature or fix that you think someone else could take up - please say so - and if there isn't one already, file an issue for the topic. Thank you for your contribution.
lgtm, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable stale bot to mark PRs stale and eventually close stale PRs. I had tried to manually do this in the past with nice comments but I forget to do it and trying to be nice was unrewarding. I find a bunch of old PRs in the list a distraction and don't want to have to think about them or try to follow up on them. I want to be generous to PR authors so PRs can be inactive for 60 days and one has 3 weeks to unstale the PR.
Workflows only change.