Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig.json: Move types into compilerOptions #60

Merged
merged 1 commit into from
Nov 20, 2023
Merged

tsconfig.json: Move types into compilerOptions #60

merged 1 commit into from
Nov 20, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Sep 26, 2023

This fixes "Property 'env' does not exist on type 'ImportMeta'".

@zmc zmc requested a review from VallariAg September 26, 2023 19:46
@render
Copy link

render bot commented Sep 26, 2023

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit a9df945
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/6557d744a2d65d000957062b
😎 Deploy Preview https://deploy-preview-60--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zmc
Copy link
Member Author

zmc commented Nov 14, 2023

@VallariAg ping

@VallariAg
Copy link
Member

VallariAg commented Nov 17, 2023

@zmc my bad, I reviewed the PR but github kept my review in "pending" state so it was only visible to me! apparently I need to submit my reviews.

I see a Cannot find type definition file for 'src/vite-env-override.d.ts' warning in tsconfig.json. Please let me know if it's reproducible on your end, I made no extra changes to this branch.

image

For me, changing to "./src/vite-env-override.d.ts" solves this (see comment above below).

tsconfig.json Outdated
"downlevelIteration": true
"downlevelIteration": true,
"types": [
"src/vite-env-override.d.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"src/vite-env-override.d.ts",
"./src/vite-env-override.d.ts",

Fixes Cannot find type definition file for 'src/vite-env-override.d.ts'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I never saw this comment! That changed caused no issues for me, so I've repushed with it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused for a minute there too! awesome, thank you :)

This fixes "Property 'env' does not exist on type 'ImportMeta'".

Signed-off-by: Zack Cerza <[email protected]>
@zmc zmc merged commit 6e0cce0 into main Nov 20, 2023
7 checks passed
@zmc zmc deleted the fix-ts branch November 20, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants