-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsconfig.json: Move types into compilerOptions #60
Conversation
Your Render PR Server URL is https://pulpito-ng-pr-60.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ck9jacf0vg2c73bm19lg. |
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@VallariAg ping |
@zmc my bad, I reviewed the PR but github kept my review in "pending" state so it was only visible to me! apparently I need to submit my reviews. I see a For me, changing to |
tsconfig.json
Outdated
"downlevelIteration": true | ||
"downlevelIteration": true, | ||
"types": [ | ||
"src/vite-env-override.d.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"src/vite-env-override.d.ts", | |
"./src/vite-env-override.d.ts", |
Fixes Cannot find type definition file for 'src/vite-env-override.d.ts'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I never saw this comment! That changed caused no issues for me, so I've repushed with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused for a minute there too! awesome, thank you :)
This fixes "Property 'env' does not exist on type 'ImportMeta'". Signed-off-by: Zack Cerza <[email protected]>
This fixes "Property 'env' does not exist on type 'ImportMeta'".