Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table cell border (and other table UI improvements) #80

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

VallariAg
Copy link
Member

@VallariAg VallariAg commented Aug 8, 2024

This PR:

  1. Adds border to table cells
  2. disable column action buttons (three vertical dots) from columns "link", "status", and "user". This makes some space in header column of the table for displaying text. Its only disabled for these fields because column actions can be useful to hide a column from the table and these are essential columns which probably don't need to be removed from view.
  3. Link column is moved to left most to give better collected view of information.
  4. "scheduled" column is edited so date and time show up in different lines (like in pulpito). Helps to reduce column width.
  5. Only show 8 letters of "hash" column. Original pulpito has a similar view. Helps to reduce column width.
  6. Make all status columns at the end ("fail", "pass", etc) of same width to bring uniformity in the view.

Before:
image

After:
image

It makes it easier to read tables like RunList and JobList.

Signed-off-by: Vallari Agrawal <[email protected]>
Also move "link" column to left most.

Signed-off-by: Vallari Agrawal <[email protected]>
Copy link

render bot commented Aug 8, 2024

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit a4c1cf1
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/66b4e08d3d286b000806b363
😎 Deploy Preview https://deploy-preview-80--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VallariAg VallariAg changed the title Add table cell border Add table cell border (and other table UI improvements) Aug 8, 2024
@VallariAg VallariAg requested a review from zmc August 8, 2024 15:15
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this is an improvement

@zmc zmc merged commit 2342cb6 into main Aug 13, 2024
7 checks passed
@zmc zmc deleted the add-table-cell-border branch August 13, 2024 19:23
zmc added a commit that referenced this pull request Aug 13, 2024
This fixes a crash in #80.

Signed-off-by: Zack Cerza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants