stdin-killer: do not setpgrp if already leader #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes failure like:
2023-08-03T19:40:10.942 INFO:teuthology.orchestra.run.smithi100.stderr:Traceback (most recent call last):
2023-08-03T19:40:10.942 INFO:teuthology.orchestra.run.smithi100.stderr: File "/usr/bin/stdin-killer", line 213, in <module>
2023-08-03T19:40:10.943 INFO:teuthology.orchestra.run.smithi100.stderr: os.setpgrp()
2023-08-03T19:40:10.943 INFO:teuthology.orchestra.run.smithi100.stderr:PermissionError: [Errno 1] Operation not permitted
Signed-off-by: Patrick Donnelly <[email protected]>
batrick
force-pushed
the
stdin-killer-setpgrp
branch
from
5b58504
to
b5bd9a5
Compare
vshankar
reviewed
Aug 4, 2023
| pgrp = os.getpgrp() | ||
| if pgrp != os.getpid(): |
There was a problem hiding this comment.
This looks correct as EPERM errno is returned if the process calling setpgrp is the session/process group leader. Question is, what caused this failure now.
There was a problem hiding this comment.
I'm not sure but clearly under normal circumstances stdin-killer is not already the process group leader. Perhaps when it was wrapped with the ulimit wrapper.
zmc
approved these changes
Aug 4, 2023
dmick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs in https://pulpito.ceph.com/pdonnell-2023-08-03_19:12:12-fs-wip-batrick-testing-20230803.140718-distro-default-smithi/