From 86cd96d264af7c6a29dfdf0f58001db04293b7c7 Mon Sep 17 00:00:00 2001 From: Thomas E Lackey Date: Mon, 20 Nov 2023 16:51:20 -0600 Subject: [PATCH] lint --- .golangci.yml | 2 +- x/registry/client/testutil/grpc.go | 30 ++++++++++++++++-------------- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 1d0df1c3..5a744879 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -6,7 +6,7 @@ run: linters: enable: - bodyclose - - depguard +# - depguard # 20231120 disable until https://github.com/golangci/golangci-lint/issues/3906 is released - dogsled - dupl - errcheck diff --git a/x/registry/client/testutil/grpc.go b/x/registry/client/testutil/grpc.go index 143dab90..2f9f64d3 100644 --- a/x/registry/client/testutil/grpc.go +++ b/x/registry/client/testutil/grpc.go @@ -15,6 +15,8 @@ import ( tmcli "github.com/tendermint/tendermint/libs/cli" ) +const badPath = "/asdasd" + func (s *IntegrationTestSuite) TestGRPCQueryParams() { val := s.network.Validators[0] sr := s.Require() @@ -28,7 +30,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryParams() { }{ { "invalid url", - reqURL + "/asdasd", + reqURL + badPath, true, "", }, @@ -60,7 +62,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryParams() { } } -//nolint: all +// nolint: all func (s *IntegrationTestSuite) TestGRPCQueryWhoIs() { val := s.network.Validators[0] sr := s.Require() @@ -75,7 +77,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryWhoIs() { }{ { "invalid url", - reqUrl + "/asdasd", + reqUrl + badPath, true, "", func(authorityName string) { @@ -143,7 +145,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryLookup() { }{ { "invalid url", - reqURL + "/asdasd", + reqURL + badPath, true, "", func(authorityName string) { @@ -180,7 +182,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryLookup() { } } -//nolint: all +// nolint: all func (s *IntegrationTestSuite) TestGRPCQueryRecordExpiryQueue() { val := s.network.Validators[0] sr := s.Require() @@ -195,7 +197,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryRecordExpiryQueue() { }{ { "invalid url", - reqUrl + "/asdasd", + reqUrl + badPath, true, "", func(bondId string) { @@ -252,7 +254,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryRecordExpiryQueue() { } } -//nolint: all +// nolint: all func (s *IntegrationTestSuite) TestGRPCQueryAuthorityExpiryQueue() { val := s.network.Validators[0] sr := s.Require() @@ -267,7 +269,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryAuthorityExpiryQueue() { }{ { "invalid url", - reqUrl + "/asdasd", + reqUrl + badPath, true, "", func(authorityName string) { @@ -324,7 +326,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryAuthorityExpiryQueue() { } } -//nolint: all +// nolint: all func (s *IntegrationTestSuite) TestGRPCQueryListRecords() { val := s.network.Validators[0] sr := s.Require() @@ -339,7 +341,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryListRecords() { }{ { "invalid url", - reqUrl + "/asdasd", + reqUrl + badPath, true, "", func(bondId string) { @@ -409,7 +411,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryGetRecordByID() { }{ { "invalid url", - reqURL + "/asdasd", + reqURL + badPath, true, "", func(bondId string) string { @@ -478,7 +480,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryGetRecordByBondID() { }{ { "invalid url", - reqURL + "/asdasd", + reqURL + badPath, true, "", func(bondId string) { @@ -532,7 +534,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryGetRegistryModuleBalance() { }{ { "invalid url", - reqURL + "/asdasd", + reqURL + badPath, true, "", func(bondId string) { @@ -583,7 +585,7 @@ func (s *IntegrationTestSuite) TestGRPCQueryNamesList() { }{ { "invalid url", - reqURL + "/asdasd", + reqURL + badPath, true, "", func(authorityName string) {