Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate non-deterministic test failures in testutil/network/network.go #104

Closed
zramsay opened this issue Mar 17, 2023 · 2 comments
Closed

Investigate non-deterministic test failures in testutil/network/network.go #104

zramsay opened this issue Mar 17, 2023 · 2 comments

Comments

@zramsay
Copy link
Contributor

zramsay commented Mar 17, 2023 •
edited
Loading

Follow up from #74 (review) and showed up in #102.

See: https://github.com/cerc-io/laconicd/runs/12015779774
And, e.g., https://github.com/cerc-io/laconicd/security/code-scanning/
@zramsay zramsay mentioned this issue Mar 18, 2023
Merged
11 tasks
@0xmuralik
Copy link
Contributor

The mutex lock is being released in the clean up func and is not recognized by semgrep. I think this is a false positive.
https://github.com/cerc-io/laconicd/blob/main/testutil/network/network.go#L611

@telackey
Copy link
Contributor

https://git.vdb.to/cerc-io/laconicd/issues/104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@telackey @zramsay @0xmuralik