Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log noise to do with websockets #36

Closed
dboreham opened this issue Sep 27, 2022 · 9 comments
Closed

Log noise to do with websockets #36

dboreham opened this issue Sep 27, 2022 · 9 comments
Assignees
Labels
bug Something isn't working low priority

Comments

@dboreham
Copy link
Contributor

We see constant log output like this, under normal operating conditions:

Sep 27 13:37:44 vaasl-cerc-1 chibaclonkd[418747]: 1:37PM ERR Failed to read request err="websocket: close 1006 (abnormal closure): unexpected EOF" module=rpc-server protocol=websocket remote={"IP":"127.0.0.1","Port":39564,"Zone":""}
Sep 27 13:37:44 vaasl-cerc-1 chibaclonkd[418747]: 1:37PM ERR not stopping client; it is already stopped client=wsConnection module=rpc-server protocol=websocket remote={"IP":"127.0.0.1","Port":39564,"Zone":""}
Sep 27 13:37:44 vaasl-cerc-1 chibaclonkd[418747]: 1:37PM ERR error while stopping connection error="client is not running" module=rpc-server protocol=websocket

This output is not useful and clutters the log making it hard to determine if the service is operating correctly.

Task is to stop this log output from appearing, one way or another.

@dboreham dboreham self-assigned this Sep 27, 2022
@dboreham
Copy link
Contributor Author

Quick search of the laconicd source code shows that these messages are not coming from our code. Probably originate in a dependency. Checking...

@dboreham
Copy link
Contributor Author

dboreham commented Sep 27, 2022

@dboreham
Copy link
Contributor Author

dboreham commented Sep 27, 2022

Code where the messages are generated:

https://github.com/tendermint/tendermint/blob/main/rpc/jsonrpc/server/ws_handler.go#L327
https://github.com/tendermint/tendermint/blob/main/rpc/jsonrpc/server/ws_handler.go#L97

(Can't find the code for "not stopping client; it is already stopped" yet)

@dboreham
Copy link
Contributor Author

dboreham commented Sep 27, 2022

@dboreham
Copy link
Contributor Author

See also: evmos/ethermint#1253

@dboreham
Copy link
Contributor Author

Resolved by rebasing to older CosmosSDK

@dboreham
Copy link
Contributor Author

Reports are the message persists in the latest release, re-opening.

@dboreham dboreham reopened this Nov 29, 2022
@dboreham
Copy link
Contributor Author

Sample log output:

6:43AM INF executed block height=115260 module=state num_invalid_txs=0 num_valid_txs=0 server=node
6:43AM INF commit synced commit=436F6D6D697449447B5B353620313635203134332031393720393020323035203137362032313620313237203233302031203630203235302031303320313339203131342031393020313735203138332032323620313431203738203131312031373920313237203137342038312032343620363720313739203839203131335D3A31433233437D
6:43AM INF committed state app_hash=38A58FC55ACDB0D87FE6013CFA678B72BEAFB7E28D4E6FB37FAE51F643B35971 height=115260 module=state num_txs=0 server=node
6:43AM INF indexed block height=115260 module=txindex server=node
6:43AM ERR Failed to read request err="websocket: close 1006 (abnormal closure): unexpected EOF" module=rpc-server protocol=websocket remote={"IP":"127.0.0.1","Port":56880,"Zone":""} server=node
6:43AM INF service stop impl={"Logger":{}} module=rpc-server msg={} protocol=websocket remote={"IP":"127.0.0.1","Port":56880,"Zone":""} server=node
6:43AM ERR error while stopping connection error="already stopped" module=rpc-server protocol=websocket server=node
6:43AM INF Timed out dur=4951.497901 height=115261 module=consensus round=0 server=node step=1
6:43AM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"C7A902FDDDB1002AD199E0EB47ADCB83F433008F486ADCFA8311CA77EE60284A","parts":{"hash":"818CB3B392BF317DE9D4F619F72DD7BF087F5D93810F64BB589425310AFAEA49","total":1}},"height":115261,"pol_round":-1,"round":0,"signature":"6cCWcllSd1Vd2Z6F6iA6oL0Z6RENmgb31IC7voNKhApzRDb0qaEi7aYOthm4yqhwgckeWbsh8opvkNPtyXtRCA==","timestamp":"2022-11-30T06:43:50.351283628Z"} server=node
6:43AM INF received complete proposal block hash=C7A902FDDDB1002AD199E0EB47ADCB83F433008F486ADCFA8311CA77EE60284A height=115261 module=consensus server=node
6:43AM INF finalizing commit of block hash={} height=115261 module=consensus num_txs=0 root=38A58FC55ACDB0D87FE6013CFA678B72BEAFB7E28D4E6FB37FAE51F643B35971 server=node
6:43AM INF minted coins from module account amount=2654112105175373achk from=mint module=x/bank
6:43AM INF executed block height=115261 module=state num_invalid_txs=0 num_valid_txs=0 server=node

@i-norden i-norden added bug Something isn't working low priority labels Feb 28, 2023
@cerc-io cerc-io deleted a comment from github-actions bot Feb 28, 2023
@telackey
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

No branches or pull requests

3 participants