Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review/clean up Makefile #82

Closed
i-norden opened this issue Jan 13, 2023 · 4 comments
Closed

Review/clean up Makefile #82

i-norden opened this issue Jan 13, 2023 · 4 comments
Labels
low priority

Comments

@i-norden
Copy link
Contributor

i-norden commented Jan 13, 2023 •
edited
Loading

Our Makefile was inherited from ethermint, which was inherited from cosmos-sdk, and adjusted ad hoc to our needs.

We need to perform a review of the Makefile and clean out any unused utilities and adjust things to our liking.
@i-norden
Copy link
Contributor Author

Also provide better documentation for what the commands are doing

@zramsay
Copy link
Contributor

zramsay commented Jan 18, 2023 •
edited
Loading

currently make build/install will use the latest tag found locally (not the expected behaviour of building from whatever your latest code locally is)

For testing, publish a new tag locally then run, e.g., make VERSION=v0.7.1 install

@zramsay zramsay mentioned this issue Jan 20, 2023
Closed
@ABastionOfSanity
Copy link
Contributor

goreleaser is high on my list for this. I think it can be removed.

@telackey
Copy link
Contributor

https://git.vdb.to/cerc-io/laconicd/issues/82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ABastionOfSanity @telackey @zramsay @i-norden