Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --allow-weak-hashes instead of disabling signature verification entirely #6

Open
DemiMarie opened this issue Mar 4, 2022 · 6 comments

Comments

@DemiMarie
Copy link

rpmcanon provides the --allow-weak-hashes argument to allow packages signed with SHA-1 to be installed, which is (much) better than turning off signature verification.

@cfcs
Copy link
Owner

cfcs commented Apr 2, 2022

@DemiMarie That sounds great, what is rpmcanon ?

@DemiMarie
Copy link
Author

@DemiMarie That sounds great, what is rpmcanon ?

It’s a Rust tool for canonicalizing RPM packages, verifying the signatures, and stripping anything nasty in them. Qubes OS uses it for all dom0 updates and for all calls to qvm-template (no matter which qube they are made from).

@cfcs
Copy link
Owner

cfcs commented Apr 13, 2022

Is it possible to get qubes-update-dom0 to pass --allow-weak-hashes or what is your suggested approach?

@DemiMarie
Copy link
Author

Is it possible to get qubes-update-dom0 to pass --allow-weak-hashes or what is your suggested approach?

Not directly, though one can patch /etc/qubes-rpc/qubes.RecieveUpdates. That said, we should really get ZFS to sign its RPMs with a better hash, since SHA-1 support in signatures is going away.

@cfcs
Copy link
Owner

cfcs commented Apr 24, 2022

openzfs/zfs#13176 (comment)
Looks like you succeeded in getting it fixed upstream!

@DemiMarie
Copy link
Author

openzfs/zfs#13176 (comment) Looks like you succeeded in getting it fixed upstream!

Yup! Time to turn signature verification back on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants