Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading levels show line heights of .5 over what is documented #1758

Open
anselmbradford opened this issue Sep 29, 2023 · 2 comments
Open

Heading levels show line heights of .5 over what is documented #1758

anselmbradford opened this issue Sep 29, 2023 · 2 comments

Comments

@anselmbradford
Copy link
Member

anselmbradford commented Sep 29, 2023

Describe the bug

Visit https://cfpb.github.io/design-system/foundation/headings and inspect the web heading levels and check the computed styles and see that the line-heights are .5 higher than what's documented

image

@natalia-fitzgerald @jenn-franklin

@jenn-franklin
Copy link
Member

I've made a note of this in our audit.

@Scotchester
Copy link
Contributor

👋

A little historical context: I remember us intentionally making the decision to set all heading line heights to 1.25 for simplicity. I feel like it's likely that the documented line heights were simplified as a result, to avoid documenting a decimal value, but I could be mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants