Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 40 - added missing validations #45

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

nargis-sultani
Copy link
Contributor

No description provided.

@github-actions
Copy link

Coverage report

The coverage rate went from 81.08% to 81.08% ⬆️
The branch rate is 65%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Copy link
Contributor

@aharjati aharjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. heads up: main branch has black updates so you probably need to run black formatter after merging main into your branch.

@nargis-sultani
Copy link
Contributor Author

lgtm. heads up: main branch has black updates so you probably need to run black formatter after merging main into your branch.

Thanks. Sure.

@nargis-sultani nargis-sultani merged commit 5a9a1cf into main Sep 13, 2023
3 checks passed
@nargis-sultani nargis-sultani deleted the features/40_add_missing_validations branch September 13, 2023 15:09
jcadam14 pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants