Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Testing help needed? #13

Open
OrlandoSoto opened this issue May 19, 2015 · 9 comments
Open

Testing help needed? #13

OrlandoSoto opened this issue May 19, 2015 · 9 comments

Comments

@OrlandoSoto
Copy link
Member

I see lots of good stuff going on in here,, feel free to ask me or the software delivery team if you need help setting up browser, API, performance tests, we're more than glad to help you get started :)

We'll start setting up BDD security testing for this project soon.

@higs4281
Copy link
Member

thanks. i want to get some browser tests and js tests running before we
deploy.

On Tue, May 19, 2015 at 4:05 PM, Orlando [email protected] wrote:

I see lots of good stuff going on in here,, feel free to ask me or the
software delivery team if you need help setting up browser, API,
performance tests, we're more than glad to help you get started :)

We'll start setting up BDD security testing for this project soon.


Reply to this email directly or view it on GitHub
#13.

@imuchnik
Copy link
Member

Would be happy to help. Word of caution: Often to get js tests going, code may need to be refactored. So keep that in mind when estimating.
I am going to volunteer @contolini for this as well.

@OrlandoSoto
Copy link
Member Author

@higs4281 where's the front end for this project? is it possible to get a localhost instance going on my mac?

@higs4281
Copy link
Member

it's a self-contained one-page app; page is in retirement_api/templates.
local resources are in retirement_api/static. it's intended to run inside consumerfinance.gov, so we use site resources as well that won't work stand-alone.

@OrlandoSoto
Copy link
Member Author

ok, one thing that would be extremely helpful is to use unique ID's for elements that the user will interact with,, similar to what you did with the retirement age selector in step 3:

{% trans "Choose age" %} 62 63 64 65 66 67 68 69 70

@imuchnik
Copy link
Member

@Ooblioob @higs4281 @mistergone

We should really not deploy without testing. The bare essentials for front end (unit) testing are:

  1. testing framework
  2. Code coverage tool
    Lets talk about it some time next week to see if we can get these things worked out.
    Perhaps a front end code review with myself and @contolini to make sure we are not creating another "snowflake"

@contolini
Copy link
Member

The front-end's logic has grown complex. A small amount of refactoring would allow unit tests to be written for it. Shoot me an email if you'd like some help with this.

@mistergone
Copy link
Member

I'm all ears. I'm also booked solid for a week or so. That said, I'm pretty good with writing unit-testable code, but I need some guidance on what our current tools are and how we're working them.

I ain't afraid of no tests.

@imuchnik
Copy link
Member

@mistergone Great! Schedule a time most convenient to you. In the mean time, @contolini and I can do a code review and make refactoring suggestions. To start, can we change the file structure, so that javascript code is not buried inside api directory and not add more code into one giant file?

Let me know what you think

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants