Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot testing - Part 3] Shared lending platform #1087

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Dec 11, 2024

Closes #1062
Closes #1090

Changes

This PR builds off of #1072, so includes all of those commits, but is separate to emphasize this PR's focus on adding snapshots to the shared-lending-platform tests. Once #1072 is reviewed and merged, this PR should be much easier to review.

  • Add snapshot checks to E2E Shared Lending Platform tests

How to test this PR

  1. yarn test:e2e:snapshot
  2. Run shared-filing-platform tests

Screenshots

Screenshot 2024-12-12 at 10 19 08 AM

…variable (SBL_ENABLE_PLAYWRIGHT_SNAPSHOT_TESTING)
…variable (SBL_ENABLE_PLAYWRIGHT_SNAPSHOT_TESTING)
… .snapshot-ignore to the element) to simplify the process
@meissadia meissadia force-pushed the 1062-snapshot__shared-lending-platform branch from dffce7c to 9d45947 Compare December 11, 2024 21:25
@meissadia meissadia mentioned this pull request Dec 11, 2024
8 tasks
@meissadia meissadia marked this pull request as ready for review December 11, 2024 21:59
@meissadia meissadia enabled auto-merge (squash) December 11, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Snapshot testing - Add script to easily update baseline snapshots [e2e] Add snapshot testing
1 participant