generated from cfpb/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snapshot testing - Part 3] Shared lending platform #1087
Open
meissadia
wants to merge
36
commits into
main
Choose a base branch
from
1062-snapshot__shared-lending-platform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+130
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable (SBL_ENABLE_PLAYWRIGHT_SNAPSHOT_TESTING)
…variable (SBL_ENABLE_PLAYWRIGHT_SNAPSHOT_TESTING)
… .snapshot-ignore to the element) to simplify the process
…t__filing-details
…ed-lending-platform
…t__shared-lending-platform
meissadia
force-pushed
the
1062-snapshot__shared-lending-platform
branch
from
December 11, 2024 21:25
dffce7c
to
9d45947
Compare
meissadia
requested review from
billhimmelsbach and
tanner-ricks
as code owners
December 11, 2024 21:59
task: [Snapshots] Update docs to include snapshot testing scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1062
Closes #1090
Changes
This PR builds off of #1072, so includes all of those commits, but is separate to emphasize this PR's focus on adding snapshots to the
shared-lending-platform
tests. Once #1072 is reviewed and merged, this PR should be much easier to review.How to test this PR
yarn test:e2e:snapshot
shared-filing-platform
testsScreenshots