-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During data upload line geometry is converted to point geometry #6
Comments
There is a problem with style creation in GeoServer, I am looking into it and I created a ticket here: |
I have just deployed a PR to GeoNode that addresses the issue: The PR is already on the staging, so you can test it now. Let me know if I can close this @wendy-guan @blewis |
I just told Prof. Xu to test this on staging. |
Great. Remember, source code of the PR is still not merged in GeoNode. They need to wait until tomorrow for using it in their staging |
I only asked him to test on our staging. He just replied saying that he has tried and it worked for him as expected. Thanks! |
good :) |
Prof. Xu said the ZJU production server can't roll back for whatever reason, therefore urgently need this fix. Please make it available to Wang Lijun ASAP. Thanks! |
Uploaded line features are showing up corrected as lines in a map now, but the automatically generated thumbnail still shows features as points. |
@wendy-guan I can't replicate this in CAMP staging |
I will ask Prof. Xu to send a video and the layer - if he still experience the problem now. |
video attached. If you search for "fengxuefeng" you will find several line layers with the thumbnail as points. They were uploaded from shapefiles. |
@wendy-guan it would be interesting to know if this is still happening. On staging this looks fixed after last GeoNode updates |
"fixed after last GeoNode updates" when was it? |
You may see the time stamp of the layers with this problem in staging now. |
Please note that the problem now is: Uploaded line features are showing up corrected as lines in a map now, but the automatically generated thumbnail still shows features as points. |
oh I see, yes there is still an issue with thumbnails. Will create a ticket in GeoNode. |
Do you mean that you will not fix this, but wait for someone in the GeoNode community to fix it - which we don't know when? |
@wendy-guan I am planning to fix it but meanwhile I do that maybe someone else can take care of it |
OK, That makes sense. I will let Prof. Xu know. Thanks! |
Reopening this, I am looking again into this GeoNode bug: will keep you posted. |
I debugged the problem and it looks to be a GeoServer scalability problem. I have commented my investigation in the above GeoNode ticket. Let's wait for a response from some GeoServer expert. |
Any update on this one? Really hope we can close all issues soon and move on... |
we are really close to fix this as well @wendy-guan 👍 a PR is being tested |
@wendy-guan @blewis I just submitted a PR in GeoNode which should be able to definitely fix this: This PR is already in CAMP staging for you to test. I will let you know when it is part of GeoNode master, so that CAMP staff can update their instance. |
Prof. Xu tested on staging last night and found line layers are still generating point thumbnails. Examples are "route" and "line_of_fenxuefeng" layers. |
hi @wendy-guan this is because the PR I submitted is still not in code base. I am waiting for feedback from other developers. Meanwhile I could fork GeoNode, if this is urgent, and they can use it until PR is not merged. What do you think? |
this is the PR to keep in mind: GeoNode/geonode#5024 |
oh @wendy-guan you mean in the staging. Sorry, I will check it right now. |
yes @wendy-guan this is expected, as staging was using master as well. I reverted now to use the PR source code. In any case, could Prof Xu upload the thumbnail when this is happening until the fix is included in GeoNode source code? |
3 days ago
|
I believe that the bug in the subject of this ticket is now fixed on staging (and still not in GeoNode, we need still to merge the code). |
Yes, @wendy-guan I am aware of the problems with thumbnail generation. I will work on a fix tomorrow |
this is now fixed in staging. |
Test on staging is positive. Is the fix available for ZJU server now? |
hi @wendy-guan I was still unable to merge the PR as there is one test which is failing - I am currently working to check out why this is happening today. I will keep you updated on this process and let you know when it is available |
just sent to the CAMP staff the link to a GeoNode branch containing the fixes for this issue |
I just tested on Staging with this line layer http://128.31.22.46/layers/geonode:route_2_3 and the line layer was converted to points and the thumbnail is points. NOTE clicking on a point however returns a highlighted LINE via WFS. |
thanks @bglewis I have sent a new fix here: you can already test it in CAMP staging, will let you know when it is merged in 2.10.1 |
the PR was merged in GeoNode and will be part of GeoNode 2.10.2 which will be released shortly. |
What is the status of this now? Has it passed the test on CAMP staging? Has the fix been part of GeoNode release available to AMAP production? |
@wendy-guan the changes are included in latest geonode - I just updated CAMP. GeoNode 2.10.2 should be released in days, I will let you know when it is available. |
No description provided.
The text was updated successfully, but these errors were encountered: