Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During data upload line geometry is converted to point geometry #6

Open
blewis opened this issue Sep 5, 2019 · 42 comments
Open

During data upload line geometry is converted to point geometry #6

blewis opened this issue Sep 5, 2019 · 42 comments
Assignees
Labels
bug Something isn't working

Comments

@blewis
Copy link

blewis commented Sep 5, 2019

No description provided.

@blewis blewis added the bug Something isn't working label Sep 5, 2019
@capooti
Copy link
Contributor

capooti commented Sep 5, 2019

There is a problem with style creation in GeoServer, I am looking into it and I created a ticket here:
GeoNode/geonode#4827

@capooti
Copy link
Contributor

capooti commented Sep 6, 2019

I have just deployed a PR to GeoNode that addresses the issue:
https://github.com/GeoNode/geonode/pull/4837/files

The PR is already on the staging, so you can test it now. Let me know if I can close this @wendy-guan @blewis

@wendy-guan
Copy link

I just told Prof. Xu to test this on staging.

@capooti
Copy link
Contributor

capooti commented Sep 6, 2019

Great. Remember, source code of the PR is still not merged in GeoNode. They need to wait until tomorrow for using it in their staging

@wendy-guan
Copy link

I only asked him to test on our staging. He just replied saying that he has tried and it worked for him as expected. Thanks!

@capooti
Copy link
Contributor

capooti commented Sep 6, 2019

good :)

@wendy-guan
Copy link

Prof. Xu said the ZJU production server can't roll back for whatever reason, therefore urgently need this fix. Please make it available to Wang Lijun ASAP. Thanks!

@wendy-guan
Copy link

Uploaded line features are showing up corrected as lines in a map now, but the automatically generated thumbnail still shows features as points.

@capooti
Copy link
Contributor

capooti commented Sep 18, 2019

@wendy-guan I can't replicate this in CAMP staging

@capooti capooti added can't replicate and removed bug Something isn't working labels Sep 18, 2019
@wendy-guan
Copy link

I will ask Prof. Xu to send a video and the layer - if he still experience the problem now.

@wendy-guan
Copy link

video attached. If you search for "fengxuefeng" you will find several line layers with the thumbnail as points. They were uploaded from shapefiles.
20190918_203024.zip

@wendy-guan wendy-guan added bug Something isn't working and removed can't replicate labels Sep 18, 2019
@capooti
Copy link
Contributor

capooti commented Sep 18, 2019

@wendy-guan it would be interesting to know if this is still happening. On staging this looks fixed after last GeoNode updates

@wendy-guan
Copy link

"fixed after last GeoNode updates" when was it?

@wendy-guan
Copy link

You may see the time stamp of the layers with this problem in staging now.
http://128.31.22.46/search/?limit=20&offset=0
http://128.31.22.46/layers/geonode:line_of_fenxuefeng_1#info

@wendy-guan
Copy link

Please note that the problem now is: Uploaded line features are showing up corrected as lines in a map now, but the automatically generated thumbnail still shows features as points.

@capooti
Copy link
Contributor

capooti commented Sep 18, 2019

oh I see, yes there is still an issue with thumbnails. Will create a ticket in GeoNode.
Luckily at least this can be mitigated by uploading a thumbnail for now.

@wendy-guan
Copy link

Do you mean that you will not fix this, but wait for someone in the GeoNode community to fix it - which we don't know when?

@capooti
Copy link
Contributor

capooti commented Sep 18, 2019

@wendy-guan I am planning to fix it but meanwhile I do that maybe someone else can take care of it

@wendy-guan
Copy link

OK, That makes sense. I will let Prof. Xu know. Thanks!

@capooti
Copy link
Contributor

capooti commented Sep 20, 2019

Reopening this, I am looking again into this GeoNode bug:
GeoNode/geonode#4827

will keep you posted.

@capooti capooti reopened this Sep 20, 2019
@capooti
Copy link
Contributor

capooti commented Sep 20, 2019

I debugged the problem and it looks to be a GeoServer scalability problem. I have commented my investigation in the above GeoNode ticket. Let's wait for a response from some GeoServer expert.

@wendy-guan
Copy link

Any update on this one? Really hope we can close all issues soon and move on...

@capooti
Copy link
Contributor

capooti commented Sep 27, 2019

we are really close to fix this as well @wendy-guan 👍 a PR is being tested
I am planning to try this Tuesday as well and confirm you we are done with it too

@capooti
Copy link
Contributor

capooti commented Oct 8, 2019

@wendy-guan @blewis I just submitted a PR in GeoNode which should be able to definitely fix this:
GeoNode/geonode#5024

This PR is already in CAMP staging for you to test. I will let you know when it is part of GeoNode master, so that CAMP staff can update their instance.

@wendy-guan
Copy link

Prof. Xu tested on staging last night and found line layers are still generating point thumbnails. Examples are "route" and "line_of_fenxuefeng" layers.

@capooti
Copy link
Contributor

capooti commented Oct 11, 2019

hi @wendy-guan this is because the PR I submitted is still not in code base. I am waiting for feedback from other developers. Meanwhile I could fork GeoNode, if this is urgent, and they can use it until PR is not merged. What do you think?

@capooti
Copy link
Contributor

capooti commented Oct 11, 2019

this is the PR to keep in mind: GeoNode/geonode#5024

@capooti
Copy link
Contributor

capooti commented Oct 11, 2019

oh @wendy-guan you mean in the staging. Sorry, I will check it right now.

@capooti
Copy link
Contributor

capooti commented Oct 11, 2019

yes @wendy-guan this is expected, as staging was using master as well. I reverted now to use the PR source code. In any case, could Prof Xu upload the thumbnail when this is happening until the fix is included in GeoNode source code?

@wendy-guan
Copy link

3 days ago
@wendy-guan @blewis I just submitted a PR in GeoNode which should be able to definitely fix this:GeoNode/geonode#5024 This PR is already in CAMP staging for you to test. I will let you know when it is part of GeoNode master, so that CAMP staff can update their instance.

I might have misunderstood the above message - as to what was fixed by the PR where and when. Anyway, just let me know when this bug is fixed on staging so I can ask Prof. Xu to test again.

@capooti
Copy link
Contributor

capooti commented Oct 11, 2019

I believe that the bug in the subject of this ticket is now fixed on staging (and still not in GeoNode, we need still to merge the code).
I start thinking that the thumanail issue is generated by another (similar) problem in a different part of GeoNode. Will look into this on Tuesday and let you know.

@wendy-guan
Copy link

Prof. Xu tested again on staging, and the result is inconsistent, some line layers generated line thumbnails, others still generated point thumbnails. See attached.
Snap2

@capooti
Copy link
Contributor

capooti commented Oct 14, 2019

Yes, @wendy-guan I am aware of the problems with thumbnail generation. I will work on a fix tomorrow

@capooti
Copy link
Contributor

capooti commented Oct 16, 2019

this is now fixed in staging.

@wendy-guan
Copy link

Test on staging is positive. Is the fix available for ZJU server now?

@capooti
Copy link
Contributor

capooti commented Oct 17, 2019

hi @wendy-guan I was still unable to merge the PR as there is one test which is failing - I am currently working to check out why this is happening today. I will keep you updated on this process and let you know when it is available

@capooti
Copy link
Contributor

capooti commented Oct 18, 2019

just sent to the CAMP staff the link to a GeoNode branch containing the fixes for this issue
https://github.com/capooti/geonode/tree/camp-before-2.10.1-merge

@blewis
Copy link
Author

blewis commented Nov 14, 2019

I just tested on Staging with this line layer http://128.31.22.46/layers/geonode:route_2_3 and the line layer was converted to points and the thumbnail is points. NOTE clicking on a point however returns a highlighted LINE via WFS.

@blewis blewis reopened this Nov 14, 2019
@capooti
Copy link
Contributor

capooti commented Nov 14, 2019

thanks @bglewis I have sent a new fix here:
GeoNode/geonode#4827

you can already test it in CAMP staging, will let you know when it is merged in 2.10.1

@capooti
Copy link
Contributor

capooti commented Nov 15, 2019

the PR was merged in GeoNode and will be part of GeoNode 2.10.2 which will be released shortly.
Meanwhile CAMP staff can use the above branch - which is also installed in CAMP staging

@wendy-guan
Copy link

What is the status of this now? Has it passed the test on CAMP staging? Has the fix been part of GeoNode release available to AMAP production?

@capooti
Copy link
Contributor

capooti commented Dec 11, 2019

@wendy-guan the changes are included in latest geonode - I just updated CAMP.

GeoNode 2.10.2 should be released in days, I will let you know when it is available.
But until then it is safe to use GeoNode 2.10.x branch - that code is already used by a number of GeoNode instances worldwide:

https://github.com/GeoNode/geonode/tree/2.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants