Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title is required to set notify popup dialog label #107

Closed
kirsty-hames opened this issue Jan 29, 2024 · 1 comment · Fixed by #108
Closed

Title is required to set notify popup dialog label #107

kirsty-hames opened this issue Jan 29, 2024 · 1 comment · Fixed by #108
Assignees
@kirsty-hames
Labels
accessibility released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

As per Core issue Notify role="dialog" requires a label. The popup uses the title to set the dialog label.

Expected behaviour

Title should be set to required as without this, the popup dialog won't be properly identified by assistive technologies.
@kirsty-hames kirsty-hames self-assigned this Jan 29, 2024
@kirsty-hames kirsty-hames mentioned this issue Jan 29, 2024
Merged
oliverfoster pushed a commit that referenced this issue Jan 30, 2024
@kirsty-hames
Fix: Title is required to set notify popup dialog label (fixes #107) (#…
8a57e3c 
…108)
github-actions bot pushed a commit that referenced this issue Jan 30, 2024
@semantic-release-bot
Chore(release): 2.8.1 [skip ci]
071bff9 
## [2.8.1](v2.8.0...v2.8.1) (2024-01-30)

### Fix

* Title is required to set notify popup dialog label (fixes #107) (#108) ([8a57e3c](8a57e3c)), closes [#107](#107) [#108](#108)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Title is required to set notify popup dialog label (fixes #107) cgkineo/adapt-visua11y
1 participant
@kirsty-hames