Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy nav btn float #111

Closed
kirsty-hames opened this issue Mar 13, 2024 · 1 comment · Fixed by #112
Closed

remove legacy nav btn float #111

kirsty-hames opened this issue Mar 13, 2024 · 1 comment · Fixed by #112
Assignees
@kirsty-hames
Labels
enhancement New feature or request released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

The nav button float style is no longer required since the plugin was updated to support data-order.

Core also overrides any .nav__btn float styles.
@kirsty-hames kirsty-hames added the enhancement New feature or request label Mar 13, 2024
@kirsty-hames kirsty-hames self-assigned this Mar 13, 2024
@kirsty-hames kirsty-hames mentioned this issue Mar 13, 2024
Merged
kirsty-hames added a commit that referenced this issue Mar 18, 2024
@kirsty-hames
Update: remove legacy nav btn float (fixes #111) #112
4a0d41f
github-actions bot pushed a commit that referenced this issue Mar 18, 2024
@semantic-release-bot
Chore(release): 2.9.0 [skip ci]
98bbb4f 
# [2.9.0](v2.8.2...v2.9.0) (2024-03-18)

### Chore

* Update releases.yml to v3 ([f952a65](f952a65))

### Update

* remove legacy nav btn float (fixes #111) #112 ([4a0d41f](4a0d41f)), closes [#111](#111) [#112](#112)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kirsty-hames added a commit that referenced this issue Apr 16, 2024
@kirsty-hames
merge pull/112 (#114)
855b860 
* Update: remove legacy nav btn float (fixes #111) #112

* Chore(release): 2.9.0 [skip ci]

# [2.9.0](v2.8.2...v2.9.0) (2024-03-18)

### Chore

* Update releases.yml to v3 ([f952a65](f952a65))

### Update

* remove legacy nav btn float (fixes #111) #112 ([4a0d41f](4a0d41f)), closes [#111](#111) [#112](#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: remove legacy nav btn float (fixes #111) cgkineo/adapt-visua11y
1 participant
@kirsty-hames