Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug inside RecyclerView #17

Open
AngleV opened this issue Jul 17, 2018 · 1 comment
Open

Bug inside RecyclerView #17

AngleV opened this issue Jul 17, 2018 · 1 comment

Comments

@AngleV
Copy link

AngleV commented Jul 17, 2018

Hello

i am using your awesome library in one of my projects and i have discover the following bug

Having a viewpager inside a recyclerview.
I'm overiding the onViewRecycled and i save in a HashMap what item was visible in the viewpager at that recyclerview position.

Next time i bind this item again if there is in hashmap i set the correct item to be selected in viewpager.
It works perfect.

The problem is that the indicator is in wrong position.
For example in a viewpager with 3 items i swipe to the last.
After the recycling the viewpager show correctly the last item but the indicator is in position 2.

@winnerawan
Copy link

winnerawan commented Jan 31, 2019

@AngleV i got same issue, take a look on other library, maybe related to this ? Did your issue already resolved?

PageIndicatorView

Because setViewPagerId uses an instance of ViewPager, using it in recycler could lead to id conflicts, so PageIndicatorView will not know properly what is the right ViewPager to work with. Instead you should handle selected indicators on your own programatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants