Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I use ESM and MSA inputs in chai-1 simultaneously? #160

Open
ASIWU opened this issue Nov 20, 2024 · 2 comments
Open

Can I use ESM and MSA inputs in chai-1 simultaneously? #160

ASIWU opened this issue Nov 20, 2024 · 2 comments
Labels
question Further information is requested

Comments

@ASIWU
Copy link

ASIWU commented Nov 20, 2024

Description

I have a question regarding the interaction between MSA input and ESM embeddings in the chai-1 model.

Current Understanding

The model supports both MSA input and ESM embeddings
There is a parameter use_esm_embeddings to control the usage of ESM embeddings

Question

When providing MSA input to the model, does the use_esm_embeddings parameter have any effect on the model's behavior? I would like to understand:

  • If MSA and ESM embeddings can be used simultaneously
  • If there is any priority between these two input types
  • Whether the use_esm_embeddings parameter is ignored when MSA input is provided

Thank you for any clarification on this matter.

@joshim5
Copy link
Contributor

joshim5 commented Nov 20, 2024

Yes, MSA and ESM embeddings can be used simultaneously.

@arogozhnikov arogozhnikov added the question Further information is requested label Nov 20, 2024
@arogozhnikov arogozhnikov changed the title Question about use_esm_embeddings parameter when using MSA input in chai-1 Using ESM and MSA inputs in chai-1 simultaneously Nov 20, 2024
@arogozhnikov
Copy link
Contributor

Model can receive both, and makes decision about their importance. More MSAs -> higher weight of this information source.

use_esm_embeddings works the same, doesn't matter if MSAs were provided or not

@arogozhnikov arogozhnikov changed the title Using ESM and MSA inputs in chai-1 simultaneously Can I use ESM and MSA inputs in chai-1 simultaneously? Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants