feat: Add logrotate for log rotation
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path is now run/munge since `run/` is considered more standard, but `chmod` call was not updated. This caused the install hook to fail. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
|
Lint failure is not due to changes in this pull request. Oddly enough, this issue is not reported on my local set up :/ |
jedel1043
approved these changes
Jun 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
logrotateto the snap build recipe. Logrotate will run once a day at midnight as a oneshot service. If logrotate rotates the logs out, it will send a signal to Slurm to reopen new log files. Pull request also contains complimenting unit tests for the_setup_logrotatemethod that I added to the install hook.Misc
Fixes #7
Discovered this bug when I was testing the logrotate-specific bits in the install hook on a test runner.