Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When withoutMongo, records still require an id, or they silently fail. #3

Open
ggn06awu opened this issue Jan 16, 2016 · 1 comment

Comments

@ggn06awu
Copy link

Turns out when trying to tie in a pub/sub using withoutMongo: true, our messages never get sent out again to subscribers, yet a manual PSUBSCRIBE in redis on the same channel picked them up fine. We later discovered the cause was not having an id on the original message object.

The offending line from observe-changes.js:

ids = !message.id || _.isArray(message.id) ? message.id : [message.id];

I've made an id from our specific use case, but can we please add some validation and / or remove the requirement for an id (object hash + timestamp + rand() ?) in this scenario please?

@artpolikarpov
Copy link
Contributor

Will think about it. Nice that you found a workaround.

P. S. I use withoutMongo:true option only with upsert and remove and I also add an hardcoded _id to the selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants