-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to packages.chef.io #4316
Open
dishanktiwari2501
wants to merge
6
commits into
main
Choose a base branch
from
dt/remove_package_chef_io
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-web-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Dishank Tiwari <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
IanMadd
force-pushed
the
dt/remove_package_chef_io
branch
from
October 16, 2024 18:37
630f782
to
70e05df
Compare
Signed-off-by: Ian Maddaus <[email protected]>
IanMadd
force-pushed
the
dt/remove_package_chef_io
branch
from
October 16, 2024 18:38
70e05df
to
5c145cf
Compare
Quality Gate passedIssues Measures |
IanMadd
reviewed
Oct 23, 2024
IanMadd
reviewed
Nov 7, 2024
+ @Karunesh ***@***.***>, @rahul ***@***.***>
@ian ***@***.***> we need to share all PRs with all EMs to get the confirmation if all new links are correct and working before, we publish the changes in doc. I think this is not the entire list.
________________________________
From: Ian Maddaus ***@***.***>
Sent: Thursday, November 7, 2024 6:05 AM
To: chef/chef-web-docs ***@***.***>
Cc: Sonia Arora ***@***.***>; Mention ***@***.***>
Subject: Re: [chef/chef-web-docs] Remove references to packages.chef.io (PR #4316)
@IanMadd commented on this pull request.
________________________________
In content/install_bootstrap.md<#4316 (comment)>:
@@ -373,7 +379,7 @@ $file = "C:\Windows\System32\drivers\etc\hosts"
$hosts | Add-Content $file
## Download the Chef Infra Client
-$clientURL = "https://packages.chef.io/files/stable/chef/12.19.36/windows/2012/chef-client-<https://packages.chef.io/files/stable/chef/12.19.36/windows/2012/chef-client-><version-here>.msi"
+$clientURL = "https://chefdownload-commercial.chef.io/files/stable/chef/12.19.36/windows/2012/chef-client-<https://chefdownload-commercial.chef.io/files/stable/chef/12.19.36/windows/2012/chef-client-><CLIENT_VERSION>.msi"
Will this work?
—
Reply to this email directly, view it on GitHub<#4316 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3WVCYPTJERPGAETR6RS6ETZ7NXUNAVCNFSM6AAAAABPT7FXPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRRGA3TSMRRGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
IanMadd
reviewed
Nov 7, 2024
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Please describe what this change achieves]
Definition of Done
Issues Resolved
https://progresssoftware.atlassian.net/browse/CHEF-15020
Related PRs
Check List