Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards should not be dealt right after the user joins the table #299

Open
piggydoughnut opened this issue Jul 6, 2020 · 3 comments
Open
Assignees

Comments

@piggydoughnut
Copy link
Collaborator

How it works now

Cards are dealt right after the user successfully joins the table (makes a socket connection to backend)

Suggestion

We should get rid of dealing cards after joining the table and let the dealer pres start to deal cards for the game.

Thoughts?

@norbertdragan
Copy link
Collaborator

Yes, that should not happen. Cards should be dealt based on when the players are receiving their card info from the backend.

@piggydoughnut piggydoughnut transferred this issue from chips-blockchain/bet Aug 18, 2020
@piggydoughnut piggydoughnut self-assigned this Aug 18, 2020
@piggydoughnut
Copy link
Collaborator Author

@sg777 the cards are dealt because the frontend receives deal message right after the user sits down. Could we only send the deal once the dealer starts the game? Would that be possible?

@NutellaLicka
Copy link

The dealer should not have any manual selections on their side (we do not want people to actually have to be at their computer to deal manually). Maybe this could be an option for private tables.

Public tables, by default, should start the hand after:

  • N number of people sit at the table (a dealer settable option I'd say) and 10s passes (to allow more people to sit down), or
  • once all seats are filled, or
  • after X amount of time passes (I'd say between 15-30s) AND the dealer has not set an N amount of players.

Example 1
A table has 9 seats and the dealer sets 5 as the minimum for game start (5/9 to start). The table has 4 people join it. The game does not start.
A 5th person joins and 10s passes. The game is dealt.

Example 2
A table has 9 seats and the dealer has not set N amount of players to start (2/9 as you need a minimum 2 players to play a game). The table has 1 person on it. It does not start.
A 2nd person joins the table and 15-30s passes without anybody else joining. The game is dealt. Following that hand, the dealer waits 30s, a 3rd and 4th person join. After waiting the amount of time, the hand is dealt.

Example 3
A table has 9 seats and the dealer has set 7 players minimum to start (7/9). The table has 8 players and finishes a hand. The game listens for anybody sitting down and the next hand is automatically started as there is >=7players on the table.

Example 4 (private table)
A table has 9 seats and the dealer sets manual gameplay. 7 Players join the table. The dealer is happy with that number and selects 'start dealing' (or some other button). The game is played and finishes after 1 hand. When the dealer is ready for another hand, they select 'start dealing'. The game finishes another hand and stops.
At this point, the dealer is sick of manually starting the game and selects 'continue dealing'. This option would automatically start the hand once the last is finished.
After a few hands, the dealer wants another friend to join so they deselect 'continue dealing'. Following that hand, the dealing is stopped and another person joins the game. The dealer reselects 'continue dealing' and the game is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants