Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP address contains white spaces #411

Open
jorian opened this issue Feb 8, 2021 · 3 comments
Open

IP address contains white spaces #411

jorian opened this issue Feb 8, 2021 · 3 comments

Comments

@jorian
Copy link

jorian commented Feb 8, 2021

image

The input that is put in on this screen:

image

Should be cleansed of any non-valid IP-address character transgressions.

Possible solution: use a regular expression to clean the input.

@piggydoughnut
Copy link
Collaborator

@satindergrewal we are not going to have this "entering your IP" setup for alpha as we will use Tor networking right? We might just let this issue slide.

@jorian
Copy link
Author

jorian commented Feb 12, 2021

If this is only for development, then this issue is indeed irrelevant.

@satindergrewal
Copy link

@satindergrewal we are not going to have this "entering your IP" setup for alpha as we will use Tor networking right? We might just let this issue slide.

I still think despite having any future solutions, we should have advanced options for advanced users. So, still a good idea to sanitise the input given by user to the address field.

We can possibly hide it in some advanced options later on in design, but it's still a good to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants