Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license checking #115

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Add license checking #115

merged 2 commits into from
Jun 18, 2021

Conversation

wtatarski
Copy link
Contributor

Fixes #103

@wtatarski wtatarski requested a review from tmichalak June 2, 2021 15:44
@wtatarski wtatarski force-pushed the add-license-checking-gha branch 2 times, most recently from 4369ab3 to 1652342 Compare June 4, 2021 09:44
@wtatarski wtatarski requested a review from mithro June 4, 2021 11:20
@wtatarski wtatarski force-pushed the add-license-checking-gha branch 7 times, most recently from d211479 to 1b5708c Compare June 7, 2021 13:49
@wtatarski wtatarski force-pushed the add-license-checking-gha branch 2 times, most recently from ffc20bf to 093dd3d Compare June 7, 2021 14:46
@wtatarski wtatarski force-pushed the add-license-checking-gha branch 2 times, most recently from d0f50b6 to 1cf3d12 Compare June 8, 2021 11:55
@wtatarski wtatarski mentioned this pull request Jun 8, 2021
Merged
@wtatarski wtatarski requested review from mithro and acomodi June 8, 2021 15:46
acomodi
acomodi approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @mithro PTAL, I think this is ready for another review.

@mithro
Copy link
Collaborator

mithro commented Jun 10, 2021

@wtatarski - You should be resolving the comments on the pull request when they are fixed.

tmichalak
tmichalak approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtatarski wtatarski force-pushed the add-license-checking-gha branch from 1cf3d12 to 8dec41e Compare June 17, 2021 16:15
@wtatarski
Add license check action
eaf3d86 
Signed-off-by: Wojciech Tatarski <[email protected]>
@wtatarski wtatarski force-pushed the add-license-checking-gha branch from 8dec41e to 2a5b3d2 Compare June 17, 2021 16:21
@wtatarski
Add missing license headers
83e0b4f 
Signed-off-by: Wojciech Tatarski <[email protected]>
@wtatarski wtatarski force-pushed the add-license-checking-gha branch from 2a5b3d2 to 83e0b4f Compare June 17, 2021 16:24
mithro
mithro approved these changes Jun 18, 2021
View reviewed changes
Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgugala kgugala merged commit d2a6779 into chipsalliance:master Jun 18, 2021
@umarcor umarcor deleted the add-license-checking-gha branch March 28, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomodi acomodi acomodi approved these changes

@tmichalak tmichalak tmichalak approved these changes

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license checking github action
5 participants
@wtatarski @mithro @tmichalak @acomodi @kgugala