-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFP - friction #1449
Comments
Package Request ValidationWe have finished some basic validation of this request. The result of this validation can be found below: Request Issues to fixWe have found the following issues with this request. Please update the issue to reflect any necessary changes mentioned.
New Maintainer NoticesThis section details some parts of the request that any upcoming maintainer may need to take into consideration. File Validation Output
Please note that this check is currently in alpha, and may not be able to detect everything correctly. |
https://friction.graphics/ is a valid URL |
Is it on the same line? |
I've had a look at the code, and unfortunately, I can't see where the issues lies. I'll leave that to @AdmiringWorm. In the meantime I'll change the labels. |
The bot currently only thinks any URL that has the top-level domain of a maximum of 6 characters is valid. As the specified URL has an 8-character top-level domain, it isn't considered a valid one by the bot. |
I thought the same and I amended this line to |
That is the line that needs to be updated, as well as line 59 as well. |
@pauby the top domain validation is now fixed and should allow top domains of up to 10 characters now. |
Checklist
Package Details
Software project URL : https://friction.graphics
Direct download URL for the software / installer : https://github.com/friction2d/friction/releases/download/v0.9.4/friction-0.9.4-setup-win64.exe
Software summary / short description: an open-source, vector-based application designed for creating web animations and videos.
The text was updated successfully, but these errors were encountered: