Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFP - friction #1449

Open
4 tasks done
luzpaz opened this issue Sep 6, 2023 · 9 comments
Open
4 tasks done

RFP - friction #1449

luzpaz opened this issue Sep 6, 2023 · 9 comments

Comments

@luzpaz
Copy link

luzpaz commented Sep 6, 2023

Checklist

  • The package I am requesting does not already exist on https://community.chocolatey.org/packages;
  • There is no open issue for this package;
  • The issue title starts with 'RFP - ';
  • The download URL is public and not locked behind a paywall / login;

Package Details

Software project URL : https://friction.graphics
Direct download URL for the software / installer : https://github.com/friction2d/friction/releases/download/v0.9.4/friction-0.9.4-setup-win64.exe
Software summary / short description: an open-source, vector-based application designed for creating web animations and videos.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Package Request Validation

We have finished some basic validation of this request. The result of this validation can be found below:

Request Issues to fix

We have found the following issues with this request. Please update the issue to reflect any necessary changes mentioned.

  • We could not detect that you have provided a URL to the software project site, please add this to the 'Software project URL:' part of the template.

New Maintainer Notices

This section details some parts of the request that any upcoming maintainer may need to take into consideration.

File Validation Output

TrID/32 - File Identifier v2.24 - (C) 2003-16 By M.Pontello
Definitions found:  16497
Analyzing...

Collecting data from file: C:\Users\RUNNER~1\AppData\Local\Temp/software.tmp
 62.9% (.EXE) Inno Setup installer (109740/4/30)
 23.8% (.EXE) Win32 EXE PECompact compressed (generic) (41569/9/9)
  6.0% (.EXE) Win64 Executable (generic) (10523/12/4)
  2.5% (.EXE) Win32 Executable (generic) (4505/5/1)
  1.1% (.EXE) Win16/32 Executable Delphi generic (2072/23)

Please note that this check is currently in alpha, and may not be able to detect everything correctly.
Humans may also be able to detect other issues with this request.

@github-actions github-actions bot added the Status: Incomplete Request For issues where not all necessary information have been filled out label Sep 6, 2023
@luzpaz
Copy link
Author

luzpaz commented Sep 6, 2023

  • We could not detect that you have provided a URL to the software project site, please add this to the 'Software project URL:' part of the template.

https://friction.graphics/ is a valid URL

@pauby
Copy link
Member

pauby commented Sep 6, 2023

Is it on the same line?

@luzpaz
Copy link
Author

luzpaz commented Sep 7, 2023

Is it on the same line?

Indeed
Screenshot_20230906_221514

@pauby
Copy link
Member

pauby commented Sep 8, 2023

I've had a look at the code, and unfortunately, I can't see where the issues lies. I'll leave that to @AdmiringWorm. In the meantime I'll change the labels.

@pauby pauby added Status: Available For Maintainer(s) and removed Status: Incomplete Request For issues where not all necessary information have been filled out labels Sep 8, 2023
@AdmiringWorm
Copy link
Member

The bot currently only thinks any URL that has the top-level domain of a maximum of 6 characters is valid. As the specified URL has an 8-character top-level domain, it isn't considered a valid one by the bot.

@pauby
Copy link
Member

pauby commented Sep 8, 2023

I thought the same and I amended this line to {1,10}. It may have been the wrong line, or I was holding it wrong, but it didn't make any difference.

@AdmiringWorm
Copy link
Member

I thought the same and I amended this line to {1,10}. It may have been the wrong line, or I was holding it wrong, but it didn't make any difference.

That is the line that needs to be updated, as well as line 59 as well.
I do not believe there is anywhere else, I'll look into it when I have time.

@AdmiringWorm
Copy link
Member

@pauby the top domain validation is now fixed and should allow top domains of up to 10 characters now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants