reek results for lib/rouster.rb

[chorankates]

not even recursive!

not sure we should fix them all, but at least triage and spot patterns

lib/rouster.rb -- 59 warnings:
  Object has no descriptive comment (IrresponsibleModule)
  Rouster has at least 17 instance variables (TooManyInstanceVariables)
  Rouster has no descriptive comment (IrresponsibleModule)
  Rouster tests @cache_timeout at least 4 times (RepeatedConditional)
  Rouster#_run calls $?.to_i twice (DuplicateMethodCall)
  Rouster#_run has approx 11 statements (TooManyStatements)
  Rouster#check_key_permissions calls ENV["USER"] 3 times (DuplicateMethodCall)
  Rouster#check_key_permissions calls check_key_permissions(key, fix) twice (DuplicateMethodCall)
  Rouster#check_key_permissions calls fix.eql?(true) twice (DuplicateMethodCall)
  Rouster#check_key_permissions calls perms[:mode] twice (DuplicateMethodCall)
  Rouster#check_key_permissions calls perms[:owner] twice (DuplicateMethodCall)
  Rouster#check_key_permissions has approx 10 statements (TooManyStatements)
  Rouster#check_key_permissions has boolean parameter 'fix' (BooleanParameter)
  Rouster#disconnect_ssh_tunnel performs a nil-check. (NilCheck)
  Rouster#get has approx 6 statements (TooManyStatements)
  Rouster#get has the variable name 'e' (UncommunicativeVariableName)
  Rouster#get performs a nil-check. (NilCheck)
  Rouster#get_output calls self.output twice (DuplicateMethodCall)
  Rouster#get_ssh_info has approx 9 statements (TooManyStatements)
  Rouster#get_ssh_info has the variable name 'h' (UncommunicativeVariableName)
  Rouster#initialize calls @passthrough.eql?(true) twice (DuplicateMethodCall)
  Rouster#initialize calls @sshkey.nil? twice (DuplicateMethodCall)
  Rouster#initialize calls ENV["VAGRANT_HOME"] 3 times (DuplicateMethodCall)
  Rouster#initialize calls opts[:cache_timeout] twice (DuplicateMethodCall)
  Rouster#initialize calls opts[:passthrough] twice (DuplicateMethodCall)
  Rouster#initialize calls opts[:sshtunnel] twice (DuplicateMethodCall)
  Rouster#initialize calls opts[:unittest] 3 times (DuplicateMethodCall)
  Rouster#initialize calls opts[:vagrantfile] twice (DuplicateMethodCall)
  Rouster#initialize calls opts[:verbosity] twice (DuplicateMethodCall)
  Rouster#initialize calls raise(InternalError.new) twice (DuplicateMethodCall)
  Rouster#initialize calls self.status twice (DuplicateMethodCall)
  Rouster#initialize has the variable name 'e' (UncommunicativeVariableName)
  Rouster#initialize performs a nil-check. (NilCheck)
  Rouster#is_available_via_ssh? calls @cache[:is_available_via_ssh?] 9 times (DuplicateMethodCall)
  Rouster#is_available_via_ssh? calls @cache[:is_available_via_ssh?][:status] 3 times (DuplicateMethodCall)
  Rouster#is_available_via_ssh? calls @cache[:is_available_via_ssh?][:time] 3 times (DuplicateMethodCall)
  Rouster#is_available_via_ssh? calls Time.now twice (DuplicateMethodCall)
  Rouster#is_available_via_ssh? calls Time.now.to_i twice (DuplicateMethodCall)
  Rouster#is_available_via_ssh? calls res.nil? twice (DuplicateMethodCall)
  Rouster#is_available_via_ssh? has approx 13 statements (TooManyStatements)
  Rouster#is_available_via_ssh? has the variable name 'e' (UncommunicativeVariableName)
  Rouster#is_available_via_ssh? performs a nil-check. (NilCheck)
  Rouster#os_type has approx 9 statements (TooManyStatements)
  Rouster#put has approx 6 statements (TooManyStatements)
  Rouster#put has the variable name 'e' (UncommunicativeVariableName)
  Rouster#put performs a nil-check. (NilCheck)
  Rouster#restart has approx 14 statements (TooManyStatements)
  Rouster#restart has the variable name 'e' (UncommunicativeVariableName)
  Rouster#restart is controlled by argument wait (ControlParameter)
  Rouster#run has approx 15 statements (TooManyStatements)
  Rouster#run performs a nil-check. (NilCheck)
  Rouster#status calls @cache[:status] 9 times (DuplicateMethodCall)
  Rouster#status calls @cache[:status][:status] 3 times (DuplicateMethodCall)
  Rouster#status calls @cache[:status][:time] 3 times (DuplicateMethodCall)
  Rouster#status calls Time.now twice (DuplicateMethodCall)
  Rouster#status calls Time.now.to_i twice (DuplicateMethodCall)
  Rouster#status has approx 11 statements (TooManyStatements)
  Rouster#traverse_up has approx 8 statements (TooManyStatements)
  Rouster#traverse_up performs a nil-check. (NilCheck)