When hdbuserstore ENV entry has IP address then HANA Cleaner fails when using -vlh flag.

[Darryl-G]

Hello.

Running hanacleaner with "-vlh 127.0.0.1" if the hdbuserstore ENV entry has 127.0.0.1, then I get:

ERROR, local host, 127.0.0.1 , should be one of the hosts specified for the key, MYUSER (in case of virtual, please use -vlh, see --help for more info)

Looking at the code the determination of the variable "key_hosts" tries to trim off domain names, but this breaks IP addresses.
Maybe needs a check to see if the ENV key host string matches an IP address regex, before the FQDN trim is done.
I know that IP addresses are not ideal and a hostname (even localhost) is preferable, but 3rd party has setup the system this way. :-(

Thanks.

[dmcardlenl]

Don't know why you want to do it that way, but if you do, wouldn't localhost as -vlh be the way to go?

…

On Thu, 4 Nov 2021 at 18:08, Darryl-G ***@***.***> wrote: Hello. Running hanacleaner with "-vlh 127.0.0.1" if the hdbuserstore ENV entry has 127.0.0.1, then I get: ERROR, local host, 127.0.0.1 , should be one of the hosts specified for the key, MYUSER (in case of virtual, please use -vlh, see --help for more info) Looking at the code the determination of the variable "key_hosts" tries to trim off domain names, but this breaks IP addresses. Maybe needs a check to see if the ENV key host string matches an IP address regex, before the FQDN trim is done. I know that IP addresses are not ideal and a hostname (even localhost) is preferable, but 3rd party has setup the system this way. :-( Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#20>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANPRIZUJCRRJNBD3RXZ2OETUKK4YNANCNFSM5HL6GEXQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Darryl-G]

It was setup that way by a 3rd party. Yes, "localhost" does work, but in Prod they have 127.0.0.1 which does not work because the script is expecting only hostnames. For now I've adjusted the copy of hanacleaner.py to compensate. Feel free to close the issue if you are of the opinion that nobody else would want to use an IP address (maybe put that in the help section).

…

On Fri, 5 Nov 2021, 23:18 dmcardlenl, ***@***.***> wrote: Don't know why you want to do it that way, but if you do, wouldn't localhost as -vlh be the way to go? On Thu, 4 Nov 2021 at 18:08, Darryl-G ***@***.***> wrote: > Hello. > > Running hanacleaner with "-vlh 127.0.0.1" if the hdbuserstore ENV entry > has 127.0.0.1, then I get: > > ERROR, local host, 127.0.0.1 , should be one of the hosts specified for > the key, MYUSER (in case of virtual, please use -vlh, see --help for more > info) > > Looking at the code the determination of the variable "key_hosts" tries to > trim off domain names, but this breaks IP addresses. > Maybe needs a check to see if the ENV key host string matches an IP > address regex, before the FQDN trim is done. > I know that IP addresses are not ideal and a hostname (even localhost) is > preferable, but 3rd party has setup the system this way. :-( > > Thanks. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#20>, or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ANPRIZUJCRRJNBD3RXZ2OETUKK4YNANCNFSM5HL6GEXQ > > . > Triage notifications on the go with GitHub Mobile for iOS > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > or Android > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJOKVBPSU6YZ7RV7UU33CEDUKRQ45ANCNFSM5HL6GEXQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[chriselswede]

Hi Darryl, thanks for the hint! Please check if latest version solves your issue?

[Darryl-G]

Thanks. I will confirm tomorrow.

[Darryl-G]

Morning. Same issue as before.
hanacleaner.py reports that 127.0.0.1 should be used and I am using it with -vlh.

ERROR, local host, 127.0.0.1 , should be one of the hosts specified for the key, MYUSER (in case of virtual, please use -vlh, see --help for more info)

I check hdbuserstore with "hdbuserstore list" and I see my key with the env:

KEY MYUSER ENV : 127.0.0.1:30013 USER: MYUSER
Edit: Formatting messed up that paste, but you get the gist.

[Darryl-G]

Looking at the code, you may need to adjust this line also:
key_hosts = [env.split(':')[0].split('.')[0] for env in ENV] #if full host name is specified in the Key, only the first part is used