Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GUI for layered fog #1618

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Add a GUI for layered fog #1618

merged 4 commits into from
Sep 24, 2023

Conversation

Peregrine05
Copy link
Member

Closes #1479.
Instead of creating a more complicated GUI as shown in the issue, I decided to create a simpler one.

New:
image
image

@megamasterbloc
Copy link

maybe change layer breath to a more meaningful term like layer dispersion or layer spreading

@Peregrine05
Copy link
Member Author

It is called breadth internally, and it is an accurate term in my opinion.

@Peregrine05 Peregrine05 requested a review from leMaik September 9, 2023 19:41
@Peregrine05
Copy link
Member Author

Should I change the name of the Layer breadth control, or leave it as it is?

@jackjt8
Copy link
Member

jackjt8 commented Sep 9, 2023

Should I change the name of the Layer breadth control, or leave it as it is?

The definition of Breadth is "the the distance from one side to another". I haven't looked at the code as to exactly what it's used for but I'm pretty sure Breadth controls the vertical spread of the fog layer. Which.. technically would mean the wrong term is use?

@Peregrine05
Copy link
Member Author

Peregrine05 commented Sep 9, 2023

I wonder if Vertical spread would be a suitable replacement.

@leMaik
Copy link
Member

leMaik commented Sep 9, 2023

How about layer height?

@Peregrine05
Copy link
Member Author

How about layer height?

That would be too easily confused with Layer altitude, I believe.

@Peregrine05
Copy link
Member Author

I changed it to Layer thickness, which should be easily understandable.

@leMaik
Copy link
Member

leMaik commented Sep 23, 2023

@Peregrine05 Somehow, picking the fog color of any layer changes the color of all layers.

@Peregrine05
Copy link
Member Author

@Peregrine05 Somehow, picking the fog color of any layer changes the color of all layers.

@leMaik This is actually a limitation of the layered fog, and is mentioned in #1428.

@leMaik
Copy link
Member

leMaik commented Sep 24, 2023

Indeed, it wasn't clear how to blend the layers iirc. Can we make it obvious in the UI that the color affects all layers? Or is it obvious and I'm just blind?

@Peregrine05
Copy link
Member Author

It does not seem obvious to me. Another hint could be useful.

@megamasterbloc
Copy link

while it's a limitation of chunky I think that it's perfectly reasonable to only have one color for all fog layers. layered fog is only meant to change the distribution of fog and not it's properties

@Peregrine05
Copy link
Member Author

I have added a new note / hint to the fog GUI.

@leMaik leMaik merged commit c9e0cf5 into chunky-dev:master Sep 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI for layered fog
4 participants