Add dyed signs. #1626
Merged
Add dyed signs. #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
added
the
minecraft
|
These should be the text colors:
|
|
The text of white dyed signs is light gray in game. Do we need to multiply all of them by some factor if the sign doesn't glow? |
|
Yes, it looks like each channel is multiplied by |
|
Note to self: The outline on glowing signs is 0.4 * dye color. |
leMaik
added
backport-me
leMaik
added a commit
that referenced
this pull request
Oct 7, 2023
* Add dyed signs. * Fix sign text color outside of the extra array being ignored. * Add support for dyed signs. * Add glowing text support for all sign types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dyed signs. Dyes can be different on the front and back side of a sign.
Note that the 16 dye colors are different from the usual sign text colors (except for black). This means that we can't use the existing 4-bit palette for the dye color. In order to not have to add more bits to the palette, I made it so that if the palette contains a
1but the text mask is0, the sign texture treats the pixel as dye color, which requires only 32 or 64 bits (ie. an enum value) per sign texture.I extracted the colors via screenshots from dyed signs. They may be incorrect.
Closes #1625 and related to #789.