Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon to v2 #1619

Merged
merged 40 commits into from
Jan 2, 2024
Merged

Addon to v2 #1619

merged 40 commits into from
Jan 2, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Dec 11, 2023 •
edited
Loading

  • BRAKING: move addon to v2 (embroider / ember-auto-import v2 is now required)
  • BRAKING: there is necessary to add <BasicDropdownWormhole /> manually in application.hbs, because contentFor doesn't exists for v2 addons see installation guide
  • BRAKING: css must be imported manually, when there was not used scss/less see installation guide
  • BRAKING: For less there is necessary to add import path in ember-cli-build see installation guide
  • BRAKING: ember-basic-dropdown is now a peerDependency and must be installed as devDependencies
  • BRAKING: Fix typo isMutlipleWithSearch to isMultipleWithSearch property on <PlaceholderComponent>. This could be breaking when there was passed @placeholderComponent
  • ENHANCEMENT: Add missing properties to interface
  • INTERNAL: switch from npm to pnpm
  • INTERNAL (docs/test-app): Classic components to glimmer

mkszepp added 30 commits December 11, 2023 14:03
@mkszepp
Migrate addon to v2
14a8603
@mkszepp
Fix lint / readd some ignore rules
7adaad7
@mkszepp
activate workspace docs
09d2fc0
@mkszepp
Update ember-try / ci.yml
e8ba94d
@mkszepp
fix ci/package json
99fd866
@mkszepp
Remove .bak files
0af35e1
@mkszepp
fix pnpm lock file
3cbe79a
@mkszepp
fix ci
3661b6e
@mkszepp
Add snippets to eslintignore
d1c5e03
@mkszepp
Readd ignore rules for docs
2de0aeb
@mkszepp
Add glint/core to testapp / docs
041233f
@mkszepp
Remove glint from docs/test-app
2132335
@mkszepp
Update netlify
5fb2bf7
@mkszepp
Fix peerDep
5e29aff
@mkszepp
Cleanup test-app
0663fb0
@mkszepp
Remove generated files & fix import
9ed6b76
@mkszepp
Readd themes & fixes for export
0ce9889
@mkszepp
Add ignore prettier for vendor
fabbbe3
@mkszepp
Fix typo error isMutlipleWithSearch -> isMultipleWithSearch
2b4692d
@mkszepp
Update docs/readme
bb7ee5f
@mkszepp
Update docs
41428ae
@mkszepp
Remove ember-basic-dropdown as dependency (is now peerDependency)
da6790b
@mkszepp
Remove no-classic-classes & no-classic-components in docs & convert c…
f2d3c7b 
…lassic components to glimmer
@mkszepp
Remove ember/classic-decorator-no-classic-methods & ember/no-computed…
830f7dc 
…-properties-in-native-classes rule in docs
@mkszepp
Fix trigger @option was missing
c3f5b77
@mkszepp
Cleanup docs (remove unused components)
0d6217d
@mkszepp
Remove unused components in test-app
f805314
@mkszepp
Remove ember/classic-decorator-no-classic-methods & ember/no-computed…
dbc0efe 
…-properties-in-native-classes rule in test-app
@mkszepp
Remove ember/no-classic-components rule in test-app
f48e03d
@mkszepp
Fix helpers test
f07a5de
@mkszepp mkszepp changed the title [WIP] Addon to v2 Addon to v2 Jan 2, 2024
@mkszepp mkszepp merged commit a45863c into cibernox:master Jan 2, 2024
19 checks passed
@mkszepp mkszepp mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkszepp