Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArticleOpinionComponent has a bad smell #19

Open
casco opened this issue Oct 20, 2023 · 0 comments
Open

ArticleOpinionComponent has a bad smell #19

casco opened this issue Oct 20, 2023 · 0 comments

Comments

@casco
Copy link
Contributor

casco commented Oct 20, 2023

ArticleOpinionComponent uses the opinionToEdit to store the decision, but an instance variable "comments" to store comments?
Why is that?
The smell is visible in acceptChanges and in askGpt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@casco