internal: add a way to write portable feature tests #1592
Merged
+98
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
portable-feature-tests
branch
from
8538e32
to
d32f32c
Compare
Feature tests are used to enable new features in a backwards compatible manner. They exercise very specific code paths in the kernel. It makes sense to assume that the existing feature tests will not work as intended when porting to a new platform. Change the existing NewFeatureTest constructor to return a new sentinel error when invoked on non-Linux OS. Add a new constructor NewPortableFeatureTest which allows indicating on which platforms and versions a feature test is reliable. Signed-off-by: Lorenz Bauer <[email protected]>
lmb
force-pushed
the
portable-feature-tests
branch
from
d32f32c
to
d084e84
Compare
ti-mo
reviewed
Oct 24, 2024
| // The minimum version required for this feature. | ||
| // | ||
| // On Linux this refers to the mainline kernel version, on other platforms | ||
| // to the version of the runtime. |
There was a problem hiding this comment.
Nit: careful to distinguish between 'bpf runtime' and 'Go runtime' when phrasing things like this.
ti-mo
reviewed
Oct 24, 2024
| // NewPortableFeatureTest creates a cross-platform [FeatureTest]. | ||
| // | ||
| // versions are in the format "GOOS:Major.Minor[.Patch]" | ||
| func NewPortableFeatureTest(name string, fn FeatureTestFn, versions ...string) func() error { |
There was a problem hiding this comment.
I'm not sure why this needs to have a separate constructor. Couldn't we take Linux:6.11 and 6.11 to mean the same thing for backwards compat? (or just rewrite all the ones we have) Making version variadic in NewFeatureTest isn't a huge problem as it only has a few dozen invocations. Refactoring should be fairly straightforward.
|
For posterity: I think I accidentally deleted this code when correcting my mistake of force pushing to main. |
|
See #1592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature tests are used to enable new features in a backwards compatible manner. They exercise very specific code paths in the kernel. It makes sense to assume that the existing feature tests will not work as intended when porting to a new platform. Change the existing NewFeatureTest constructor to return a new sentinel error when invoked on non-Linux OS.
Add a new constructor NewPortableFeatureTest which allows indicating on which platforms and versions a feature test is reliable.