You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the "Prerequisites" field for each Rego test to indicate if it relies on the policy or reports API.
Motivation and context
Seehttps://github.com//pull/163 for a description of the error handling ScubaGoggles performs, relevant to this issue. Specifically:
The Provider tracks which API calls/functions succeed/fail
The Rego tests are modified to list which API calls/functions they depend on.
The Reporter checks to see if the prerequisites were met before displaying the result.
Currently, not all Rego "tests" have a Prerequisites field. As noted in a comment in the reporter, "If Prerequisites is not defined, assume the test just depends on the reports API." With the addition of the policy API, this is no longer a safe assumption.
Implementation notes
Two different options here.
Ensure that each Rego "test" has a Prerequisites field, noting its dependence on the policy, reports, or other API (e.g., groups).
Add the reports API dependency to the Rego tests that rely on that, then modify the Reporter to assume that if no prerequisites are defined, that the test just depends on the policy API.
The second option would result in less Rego changes short-term.
Acceptance criteria
The applicable Rego tests have been updated
The provider tracks whether or not the policy API call succeeds or fails
The Reporter has been updated as needed
The text was updated successfully, but these errors were encountered:
💡 Summary
Update the "Prerequisites" field for each Rego test to indicate if it relies on the policy or reports API.
Motivation and context
Seehttps://github.com//pull/163 for a description of the error handling ScubaGoggles performs, relevant to this issue. Specifically:
Currently, not all Rego "tests" have a
Prerequisites
field. As noted in a comment in the reporter, "If Prerequisites is not defined, assume the test just depends on the reports API." With the addition of the policy API, this is no longer a safe assumption.Implementation notes
Two different options here.
Prerequisites
field, noting its dependence on the policy, reports, or other API (e.g., groups).The second option would result in less Rego changes short-term.
Acceptance criteria
The text was updated successfully, but these errors were encountered: