Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update policy.md #93

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update policy.md #93

merged 1 commit into from
Sep 12, 2023

Conversation

epicfaace
Copy link
Contributor

Fix typo 18-F to 18F

@epicfaace
Update policy.md
ccf6444 
Fix typo 18-F to 18F
@jsf9k jsf9k self-assigned this Sep 12, 2023
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation labels Sep 12, 2023
@jsf9k jsf9k enabled auto-merge September 12, 2023 19:11
@jsf9k jsf9k requested a review from a team September 12, 2023 19:38
@dv4harr10
Copy link
Contributor

Hi Team, I have 3 issues on epicfaace: patch-1 branch I need to have confirmed before proceeding with approval: 1) CODEOWNERS file returns message 'contains errors'. 2) Two README files appear to be incomplete at: development-guide/dev-envs/README.md and development-guide/ethos/README.md. 3) Also, please confirm the content of these 2 files is accurate: requirements-test.txt and requirements.txt. Thanks

@jsf9k
Copy link
Member

jsf9k commented Sep 12, 2023 •
edited
Loading

Hi Team, I have 3 issues on epicfaace: patch-1 branch I need to have confirmed before proceeding with approval: 1) CODEOWNERS file returns message 'contains errors'. 2) Two README files appear to be incomplete at: development-guide/dev-envs/README.md and development-guide/ethos/README.md. 3) Also, please confirm the content of these 2 files is accurate: requirements-test.txt and requirements.txt. Thanks

  1. Can you share a link showing where you are seeing the error in the codeowners file?
  2. The incompleteness of development-guide/dev-envs/README.md and development-guide/ethos/README.md are unrelated to this PR. You should create an issue in this repo for that.
  3. The files requirements-test.txt and requirements.txt look correct to me.

@dv4harr10
Copy link
Contributor

Please see attached CODEOWNERS file.

CODEOWNERS_91223

mcdonnnj
mcdonnnj approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@jsf9k jsf9k merged commit 922e6ce into cisagov:develop Sep 12, 2023
1 check passed
@dv4harr10
Copy link
Contributor

Hi Shane, Please confirm if the README files need the separate PR in your opinion ? Or if they look ok. Thanks

@jsf9k
Copy link
Member

jsf9k commented Sep 12, 2023

Please see attached CODEOWNERS file.

CODEOWNERS_91223

This is because you're looking at the fork, not the original repo.

@dv4harr10
Copy link
Contributor

Ok Thanks for confirming it's a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epicfaace @dv4harr10 @jsf9k @mcdonnnj