Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more data about practices that aren't data-matched #1

Open
4 tasks
francisbarton opened this issue Jan 11, 2022 · 0 comments
Open
4 tasks

Provide more data about practices that aren't data-matched #1

francisbarton opened this issue Jan 11, 2022 · 0 comments

Comments

@francisbarton
Copy link
Member

The creation of full_data involves getting practice data (A) (practice code and patient age data), and then joining that up with the POMI data (B) (practice code, practice name, and patient enabled data).

Currently we do a left_join, so that only POMI data that matches a practice code from A is kept. Some practices in A don't get a match, and are currently excluded from the map.

Two or three job suggestions here:

  • Keep details of practices that don't have matching POMI data (show as NA (grey) on map?)
  • Check whether there are practices included in POMI that aren't in A (currently no checks for this) - use a full_join instead of left_join?
  • Look into whether these can be matched up through a little bit of adjustment (could there even be typos that affect the join?)
  • Report the missingness somewhere on the web page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant