Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PG17.0 Support - Regression tests sanity #7653

Open
14 of 43 tasks
naisila opened this issue Jul 11, 2024 · 0 comments · May be fixed by #7661
Open
14 of 43 tasks

PG17.0 Support - Regression tests sanity #7653

naisila opened this issue Jul 11, 2024 · 0 comments · May be fixed by #7661
Assignees
@colm-mchugh @m3hm3t @naisila
Labels
pg17_support

Comments

@naisila
Copy link
Member

naisila commented Jul 11, 2024 •
edited by colm-mchugh
Loading

Using the PG17 support branch, for now we have the following failing regression tests:

See below a list of all current issues. Please put your PR or branch if you are currently working in an issue.

SELECT "Constraint", "Definition" FROM table_checks WHERE relid='public.check_example_365068'::regclass;
             Constraint              |            Definition             
-------------------------------------+-----------------------------------
- check_example_other_col_check       | CHECK (other_col >= 100)
+ check_example_other_col_check       | CHECK other_col >= 100
WITH foo AS (
   MERGE INTO tbl1 USING tbl2 ON (true)
   WHEN MATCHED THEN DELETE
 ) SELECT * FROM foo;
-ERROR:  MERGE not supported in WITH query
+ERROR:  WITH query "foo" does not have a RETURNING clause
 COPY (
   MERGE INTO tbl1 USING tbl2 ON (true)
   WHEN MATCHED THEN DELETE
 ) TO stdout;
-ERROR:  MERGE not supported in COPY
+ERROR:  COPY query must have a RETURNING clause
  • Postgres now supports specifying a table access method is not supported on a partitioned table, fix tests, seen in tableam
  • PG17 explain diffs: Hash Left Join changed to Nested Loop Left Join, Hash changed to Materialize, seen in multi_explain
  • 🟪Fix extra ERROR: updating the distribution column is not allowed in MERGE actions, seen in merge
  • 🟪Fix extra ERROR: The required join operation is missing between the target's distribution column and any expression originating from the source. The issue may arise from a non-equi-join., probably same as above, seen in merge, merge_repartition2, merge_repartition1, merge_schema_sharding, merge_partition_tables, merge_vcore, merge_arbitrary
  • Fix missing ERROR: cannot execute MERGE on relation "tv" for views, seen in pgmerge
  • Fix missing ERROR: syntax error at or near "RETURNING", seen in pgmerge
  • Fix notice changed to error ERROR: The average of pg_target.id is less than citus_target.id, seen in merge_repartition2, merge_repartition1
  • Fix ERROR: table "partitioned_table_1_50" being attached contains an identity column "a", seen in generated_identity
  • 🟨Fix ERROR: unrecognized aclright: 16384, seen in generated_identity, create_single_shard_table, grant_on_sequence_propagation, grant_on_foreign_server_propagation, single_node_enterprise, multi_multiuser_master_protocol, multi_alter_table_row_level_security, shard_move_constraints
    This also leads to ERROR: replication_factor (2) exceeds number of worker nodes (1) seen in grant_on_schema_propagation
  • 🟨Extra MAINTAIN right in PG17, seen in multi_multiuser_master_protocol
SELECT relname, rolname, relacl FROM pg_class JOIN pg_roles ON (pg_roles.oid = pg_class.relowner) WHERE relname LIKE 'trivial%' ORDER BY relname;
        relname       |   rolname   |                           relacl                           
 ---------------------+-------------+------------------------------------------------------------
  trivial_full_access | full_access | 
- trivial_postgres    | postgres    | {postgres=arwdDxt/postgres,full_access=arwdDxt/postgres}
+ trivial_postgres    | postgres    | {postgres=arwdDxtm/postgres,full_access=arwdDxtm/postgres}
 (2 rows)
 select jsonb_path_query_tz('"12:34:56"', '$.time_tz().string()');
  jsonb_path_query_tz 
 ---------------------
- "12:34:56-07:00"
+ "12:34:56-08:00"
 (1 row)

📘 probably originating from the same PG commit
🟪 probably originating from the same PG commit
🟨 probably originating from new MAINTAIN thing

  • installcheck schedule failing, cdc_wal2json test fails because wal2json package is not available yet for pg17

for now, fixed by citusdata/the-process@16d4616
@naisila naisila linked a pull request Jul 25, 2024 that will close this issue
Draft
@naisila naisila mentioned this issue Oct 16, 2024
Merged
@naisila naisila changed the title PG17Beta2 Support - Regression tests sanity PG17.0 Support - Regression tests sanity Nov 10, 2024
@naisila naisila modified the milestone: multi_name_len Nov 13, 2024
@colm-mchugh colm-mchugh self-assigned this Nov 14, 2024
@colm-mchugh colm-mchugh mentioned this issue Nov 25, 2024
Open
colm-mchugh added a commit that referenced this issue Nov 25, 2024
@colm-mchugh
PG17 regress sanity (#7653): Fix test diffs in columnar schedule
8bcee73
colm-mchugh added a commit that referenced this issue Nov 25, 2024
@colm-mchugh
PG17 regress sanity (#7653): Fix test diffs in columnar schedule
15b3bf0 
Add an alternative file for columnar_paths. The diff is because of PG17 commit:
postgres/postgres@f7816ae
which enabled the planner to use statistics to estimate the cardinality
of CTE scans.

Add a helper function for columnnar_chunk_filtering. The diff is due to:
postgres/postgres@fd0398fc
which changed how subquery outputs appear in expressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colm-mchugh colm-mchugh

@m3hm3t m3hm3t

@naisila naisila

Labels
pg17_support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds PG17.0 support - Regression tests sanity citusdata/citus
3 participants
@colm-mchugh @m3hm3t @naisila