PG17 compatibility: Fix Test Failure in dml_recursive

[m3hm3t]

PostgreSQL 17 includes an enhancement that allows the optimizer to transform correlated IN subqueries into more efficient join operations.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=9f1337639

UPDATE
	second_distributed_table
SET
	dept = foo.tenant_id::int / 4
FROM
(
	SELECT baz.tenant_id FROM
	(
		SELECT
			second_distributed_table.dept, second_distributed_table.tenant_id
		FROM
			second_distributed_table, distributed_table as d1
		WHERE
			d1.tenant_id = second_distributed_table.tenant_id
		AND
			second_distributed_table.dept IN (3,4)
			AND
			second_distributed_table.tenant_id IN
			(
					SELECT s2.tenant_id
					FROM second_distributed_table as s2
					GROUP BY d1.tenant_id, s2.tenant_id
			)
	) as baz
	) as foo WHERE second_distributed_table.tenant_id = foo.tenant_id
RETURNING *;
-ERROR:  complex joins are only supported when all distributed tables are co-located and joined on their distribution columns
+ tenant_id | dept |          info          | tenant_id 
+-----------+------+------------------------+-----------
+ 14        |    3 | {"f1": 14, "f2": 196}  | 14
+ 23        |    5 | {"f1": 23, "f2": 529}  | 23
+ 24        |    6 | {"f1": 24, "f2": 576}  | 24
+ 3         |    0 | {"f1": 3, "f2": 9}     | 3
+ 33        |    8 | {"f1": 33, "f2": 1089} | 33
+ 34        |    8 | {"f1": 34, "f2": 1156} | 34
+ 4         |    1 | {"f1": 4, "f2": 16}    | 4
+ 43        |   10 | {"f1": 43, "f2": 1849} | 43
+ 44        |   11 | {"f1": 44, "f2": 1936} | 44
+ 53        |   13 | {"f1": 53, "f2": 2809} | 53
+ 54        |   13 | {"f1": 54, "f2": 2916} | 54
+ 63        |   15 | {"f1": 63, "f2": 3969} | 63
+ 64        |   16 | {"f1": 64, "f2": 4096} | 64
+ 73        |   18 | {"f1": 73, "f2": 5329} | 73
+ 74        |   18 | {"f1": 74, "f2": 5476} | 74
+ 83        |   20 | {"f1": 83, "f2": 6889} | 83
+ 84        |   21 | {"f1": 84, "f2": 7056} | 84
+ 93        |   23 | {"f1": 93, "f2": 8649} | 93
+ 94        |   23 | {"f1": 94, "f2": 8836} | 94
+(19 rows)
+

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (naisila/pg17_support@c0a5f5c). Learn more about missing BASE report.

Additional details and impacted files

@@                   Coverage Diff                   @@
##             naisila/pg17_support    #7727   +/-   ##
=======================================================
  Coverage                        ?   89.61%           
=======================================================
  Files                           ?      274           
  Lines                           ?    59689           
  Branches                        ?     7446           
=======================================================
  Hits                            ?    53492           
  Misses                          ?     4067           
  Partials                        ?     2130           

[onurctirtir]

I think we need to take a closer look into the new query plan to see how that optimization allowed Citus to run the query now, you can ping me tomorrow for us to quickly debug this together.

[naisila]

Nice fix, thanks @m3hm3t and @onurctirtir
Always appreciate a fix that avoids a new output file :)
Let's merge directly to release-13.0 and then rebase naisila/pg17_support branch

EDIT: sorry, wrong PR

accidentally approved the wrong PR

[naisila]

Let's hold off a bit more before merging this, until we are sure that nothing needs to change in the Citus codebase.

[naisila]

@m3hm3t given that we have a way to avoid an alternative output #7745, I suggest closing this PR, if you also agree.