PG17 compatibility: fix diff in tableam #7771
Open
+119
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## naisila/pg17_support #7771 +/- ##
========================================================
- Coverage 89.62% 89.61% -0.02%
========================================================
Files 274 274
Lines 59689 59689
Branches 7446 7446
========================================================
- Hits 53495 53488 -7
- Misses 4065 4070 +5
- Partials 2129 2131 +2 |
colm-mchugh
changed the title
colm-mchugh
force-pushed
the
cmchugh/pg17-tableam
branch
from
e689aa4
to
390de9b
Compare
Test `tableam` expects that this CREATE TABLE statement: `CREATE TABLE test_partitioned(id int, p int, val int) PARTITION BY RANGE (p) USING fake_am;` will produce this error: `specifying a table access method is not supported on a partitioned table` but as of this PG commit it is possible to specify an access method on a partitioned table: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=374c7a229 This fix moves the CREATE TABLE statement to pg17, and adds an additional test to show parent access method is inherited.
colm-mchugh
force-pushed
the
cmchugh/pg17-tableam
branch
from
390de9b
to
a108390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
tableamexpects that this CREATE TABLE statement:CREATE TABLE test_partitioned(id int, p int, val int) PARTITION BY RANGE (p) USING fake_am;will produce this error:
specifying a table access method is not supported on a partitioned tablebut as of this PG commit it is possible to specify an access method on a partitioned table. This fix moves the CREATE TABLE statement to pg17, and adds an additional test to show parent access method is inherited.