Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.use_feat_bank's impact on the results #48

Open
WillYao-THU opened this issue Apr 27, 2024 · 1 comment
Open

self.use_feat_bank's impact on the results #48

WillYao-THU opened this issue Apr 27, 2024 · 1 comment

Comments

@WillYao-THU
Copy link

Hi!I have a few questions:

  1. How can we decide whether self.use_feat_bank should be False or True, and what impact does this have on the results? I found the results worsened after setting self.use_feat_bank to True.
  2. Why can't self.appearance_dim be equal to zero when self.use_feat_bank is set to true?

Looking forward to your reply, thanks!

image

@inspirelt
Copy link
Collaborator

Hi, the feat bank works well when you have many views from different directions and distance to train the MLP fully. We set it to False by default because most of the public scenes does not contain sufficient view changes. And, the second question is an implementation issue, feel free to modify or improve it as you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants