Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#376] Added aria-current for menu active item. #434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[#376] Added aria-current for menu active item. #434

wants to merge 2 commits into from

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Nov 28, 2024 •
edited
Loading

Fixed #376

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added aria-current for menu active item.

Screenshots

Screenshot 2024-11-28 at 12 00 53 pm

Screenshot 2024-11-28 at 11 59 42 am

@febdao febdao added the PR: Needs review Pull request needs a review from assigned developers label Nov 28, 2024
@febdao febdao requested a review from richardgaunt November 28, 2024 01:02
@febdao febdao self-assigned this Nov 28, 2024
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://6747c382f0bc9bd54a7fb38e--civictheme-uikit.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 01:12 Inactive
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.75%. Comparing base (111194f) to head (5301031).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   13.75%   13.75%           
=======================================
  Files          27       27           
  Lines        1301     1301           
  Branches      308      308           
=======================================
  Hits          179      179           
  Misses        904      904           
  Partials      218      218

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardgaunt richardgaunt Awaiting requested review from richardgaunt

Assignees

@febdao febdao

Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WCAG 1.3.1 A: Current page shown with presentation alone (Issue 10)
1 participant
@febdao