Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline normalize and sass-breakpoint #392

Open
richardgaunt opened this issue Sep 26, 2024 · 0 comments
Open

Inline normalize and sass-breakpoint #392

richardgaunt opened this issue Sep 26, 2024 · 0 comments
Assignees
@richardgaunt
Labels
State: Done The issue is complete and waiting for a release Type: Feature Issue is a new feature request
Milestone
1.9

Comments

@richardgaunt
Copy link
Collaborator

User story

As a security manager
I want minimise our use of 3rd party packages
So that I can minimise our exposure to 3rd party vulnerabilities

Description

We use normalize and sass-breakpoint. Both these packages are small packages that we can inline.

Acceptance criteria

Given I am a developer
When I build UI Kit
Then normalize and sass-breakpoint are not installed from NPM
@richardgaunt richardgaunt added the Type: Feature Issue is a new feature request label Sep 26, 2024
richardgaunt pushed a commit that referenced this issue Oct 1, 2024
@AlexSkrypnyk
[#392] Fixed Content Link underline thickness. (#393)
0f6ca1a
@alan-cole alan-cole mentioned this issue Oct 4, 2024
Merged
7 tasks
@alan-cole alan-cole added the PR: Needs review Pull request needs a review from assigned developers label Oct 4, 2024
@alan-cole alan-cole mentioned this issue Oct 4, 2024
Merged
8 tasks
richardgaunt pushed a commit that referenced this issue Oct 6, 2024
@alan-cole
[#392] Inline CSS dependencies. (#402)
9c1e70a
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Oct 30, 2024
@fionamorrison23 fionamorrison23 added this to the 1.9 milestone Oct 30, 2024
@fionamorrison23 fionamorrison23 moved this from Todo to In Progress in UI Kit Oct 30, 2024
alan-cole added a commit that referenced this issue Nov 23, 2024
@alan-cole
[#392] Added missing box sizing border-box to missing components.
ce12cef 
- Fix subject card box-sizing.
- Fix input box-sizing.
- Fix navigation card box-sizing.
- Fix campaign image box-sizing.
- Fix iframe with background box-sizing.
alan-cole added a commit that referenced this issue Nov 26, 2024
@alan-cole
[#392] Added missing box sizing border-box to missing components.
d7cdfdd 
- Fix subject card box-sizing.
- Fix input box-sizing.
- Fix navigation card box-sizing.
- Fix campaign image box-sizing.
- Fix iframe with background box-sizing.
alan-cole added a commit that referenced this issue Nov 26, 2024
@alan-cole
[#392] Updated links in accordion to properly set light / dark.
348b5d4
richardgaunt pushed a commit that referenced this issue Dec 2, 2024
@alan-cole
[#392] Fixed inline css dependency issues. (#431)
f64bac1
@fionamorrison23 fionamorrison23 added State: Done The issue is complete and waiting for a release and removed PR: Needs review Pull request needs a review from assigned developers labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardgaunt richardgaunt

Labels
State: Done The issue is complete and waiting for a release Type: Feature Issue is a new feature request
Projects
UI Kit
Status: In Progress
Milestone
1.9
Development

No branches or pull requests
3 participants
@alan-cole @richardgaunt @fionamorrison23