Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link underline thickness is currently incorrect at 2px instead of 1px #394

Open
richardgaunt opened this issue Oct 1, 2024 · 1 comment
Open

Link underline thickness is currently incorrect at 2px instead of 1px #394

richardgaunt opened this issue Oct 1, 2024 · 1 comment
Assignees
@sonamchaturvedi28
Labels
State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Milestone
1.9

Comments

@richardgaunt
Copy link
Collaborator

Summary

Figma content link is 1px thickness on the underline
https://www.figma.com/design/i5NTcjBsg2zVjAxUvOl5oU/CivicTheme%3A-Design-System-v1.8.0?node-id=3596-136186&t=ZllSnfZFPvnJcZvG-4

But currently its 2px in the UI Kit.

PR fixing the issue has been provided
#393

Steps to reproduce

Compare
Figma:
https://www.figma.com/design/i5NTcjBsg2zVjAxUvOl5oU/CivicTheme%3A-Design-System-v1.8.0?node-id=3596-136186&t=ZllSnfZFPvnJcZvG-4

Storybook:
https://uikit.civictheme.io/?path=/story/atoms-content-link--content-link&knob-Is%20external_General=true&knob-Link%20hidden%20text_General=Link%20hidden%20text&knob-Text_General=Link%20text&knob-Theme_General=light&knob-Title_General=Link%20title&knob-URL_General=http://example.com/roytp

Observed outcome

The observed underline thickness is 2px instead of 1px

Expected outcome

The observed underline thickness is 1px
@richardgaunt richardgaunt added the Type: Defect Issue is a defect label Oct 1, 2024
@fionamorrison23 fionamorrison23 added this to the 1.9 milestone Oct 1, 2024
@github-project-automation github-project-automation bot moved this to Todo in UI Kit Oct 1, 2024
@fionamorrison23 fionamorrison23 added the PR: Ready for test Pull request is ready for manual testing label Oct 1, 2024
@sonamchaturvedi28
Copy link
Collaborator

Test Env: DEV
Test Status: PASS
Test Result:

  • Content link is 1px thickness on the underline.
image

@fionamorrison23 fionamorrison23 moved this from Todo to In Progress in UI Kit Oct 30, 2024
@fionamorrison23 fionamorrison23 moved this from In Progress to Done in UI Kit Oct 30, 2024
@fionamorrison23 fionamorrison23 added State: Done The issue is complete and waiting for a release and removed PR: Ready for test Pull request is ready for manual testing labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonamchaturvedi28 sonamchaturvedi28

Labels
State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Projects
UI Kit
Status: Done
Milestone
1.9
Development

No branches or pull requests
3 participants
@sonamchaturvedi28 @richardgaunt @fionamorrison23