Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated button mixins to live in base for improved re-usability. #408

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

alan-cole
Copy link
Collaborator

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Button mixins are used on button and chip components, so rather than place them within the button component, they should be moved into base.
  2. Aside from code structure improvements; this also fixes a compile issue when using a custom sass compilation toolkit.

Screenshots

@alan-cole alan-cole added the PR: Needs review Pull request needs a review from assigned developers label Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

@github-actions github-actions bot temporarily deployed to pull request October 11, 2024 06:35 Inactive
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.87%. Comparing base (23efae5) to head (49dbb75).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   13.87%   13.87%           
=======================================
  Files          27       27           
  Lines        1290     1290           
  Branches      307      307           
=======================================
  Hits          179      179           
  Misses        894      894           
  Partials      217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alan-cole nice incremental fix

@github-actions github-actions bot temporarily deployed to pull request October 24, 2024 12:02 Inactive
@richardgaunt richardgaunt merged commit 93fc1c6 into main Oct 25, 2024
7 checks passed
@richardgaunt richardgaunt deleted the feature/button-mixin branch October 25, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants