Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#370] Fixed sub-navigation active tabindex. #423

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Nov 10, 2024

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Fixed sub-navigation active tabindex.

Screenshots

Screenshot 2024-11-11 at 12 12 41 AM

@febdao febdao added the PR: Needs review Pull request needs a review from assigned developers label Nov 10, 2024
@febdao febdao requested a review from richardgaunt November 10, 2024 13:16
@febdao febdao self-assigned this Nov 10, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request November 10, 2024 13:19 Inactive
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 13.87%. Comparing base (a6ccd6f) to head (67d43d5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
components/00-base/collapsible/collapsible.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   13.87%   13.87%           
=======================================
  Files          27       27           
  Lines        1290     1290           
  Branches      307      307           
=======================================
  Hits          179      179           
  Misses        894      894           
  Partials      217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardgaunt richardgaunt merged commit 2ece878 into main Nov 11, 2024
7 of 8 checks passed
@richardgaunt richardgaunt deleted the feature/370-sub-nav-active-tabindex branch November 11, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants