Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#294] Slider issue #432

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[#294] Slider issue #432

wants to merge 8 commits into from

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Nov 27, 2024

Closes #294

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Fixed Image stretches the Slider height because it is not vertically constrained.
  2. The horizontal layout does not follow grid.

Screenshots

Screenshot 2024-06-24 at 7 19 12 PM
Screenshot 2024-06-24 at 7 19 27 PM

@febdao febdao added the PR: Needs review Pull request needs a review from assigned developers label Nov 27, 2024
@febdao febdao requested a review from richardgaunt November 27, 2024 05:18
@febdao febdao self-assigned this Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 13.75%. Comparing base (111194f) to head (0173163).

Files with missing lines Patch % Lines
components/03-organisms/slider/slider.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   13.75%   13.75%           
=======================================
  Files          27       27           
  Lines        1301     1301           
  Branches      308      309    +1     
=======================================
  Hits          179      179           
  Misses        904      904           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request November 27, 2024 05:21 Inactive
@febdao febdao requested a review from alan-cole November 28, 2024 03:20
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 03:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider is broken when large images are used
2 participants