Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile should use CXXFLAGS when calling CXX #43

Open
ryandesign opened this issue Mar 27, 2018 · 0 comments
Open

Makefile should use CXXFLAGS when calling CXX #43

ryandesign opened this issue Mar 27, 2018 · 0 comments

Comments

@ryandesign
Copy link

The Makefile passes $(CFLAGS) to $(CXX). It should pass $(CXXFLAGS) instead.

Furthermore, it defines its own CFLAGS, rather than honoring flags the user might supply when invoking make. This causes the build to fail if the user wants to supply flags that are required for the build to succeed.

This was discovered because liblinear is included in nmap. See the nmap bug report here: nmap/nmap#1161 and the MacPorts project's bug report here: https://trac.macports.org/ticket/53995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant