Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

byroncollins
Copy link
Contributor

  • Added documentation for running the application as a docker container
  • reorganised dockerfile to improve cache utilisation
  • Moved the application base image to a non privileged container (running in a non-root user and on a unprivileged port). Most Enterprise kubernetes distributions restrict containers by default from running as root and using privileged ports.
  • Exposed port changed from 80 to 8080
  • Modified github actions to build new container when a new git tag is created( new release)
  • Updated ASzc/change-string-case-action to v6 to resolve issue with action running unsupported nodejs version.

Would recommend also updating the overview on https://hub.docker.com/r/ckabalan/visualsubnetcalc.

closes #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add install instructions for Docker
1 participant