Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lumos): export more missing modules #729

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Jul 11, 2024

Description

This PR

  • Exporting some missing common modules, such as TransactionCollector from @ckb-lumos/lumos
  • Splitting sub-packages from @ckb-lumos/lumos so that SDK authors based on Lumos can import them on demand
  • Adding a bundler playground to estimate the bundle size

To make the app bundle smaller, developers could import from sub-packages on demand like the following demonstration:

import { type Script } from '@ckb-lumos/lumos/base'

const script:Script = {
  codeHash: '0x...',
  hashType: 'type',
  args: '0x...',
}

@homura homura requested a review from Keith-CY July 11, 2024 10:52
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jul 11, 2024 10:53am

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (ad0f66d) to head (2b621b7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #729      +/-   ##
===========================================
+ Coverage    87.21%   87.89%   +0.67%     
===========================================
  Files          133      133              
  Lines        25348    25348              
  Branches      2752     2789      +37     
===========================================
+ Hits         22107    22279     +172     
+ Misses        3201     3032     -169     
+ Partials        40       37       -3     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0f66d...2b621b7. Read the comment docs.

packages/hd/package.json Show resolved Hide resolved
@homura homura merged commit 8b10ade into develop Jul 12, 2024
9 checks passed
@homura homura deleted the export-more-functions branch July 12, 2024 02:32
@homura homura added this to the 0.24.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants