Cleanup #12
Merged
Cleanup #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how the compiler already works, and has essentially since the beginning.
We can't actually avoid a listify-rest-args. Even if there's an ignore declaration, the code might refer to the variable anyway, and then by CLHS IGNORE the most we can do is style warn.
Having it push to the stack was silly when we immediately put it into a local every time. Plus the local index is always the same as the number of fixed parameters.
Longstanding bug. I'm not super happy with the LET code, but it's kind of inherently messy and this is the best I could come up with.
karlosz suggested this months ago (in a very early CVM) and it's a good idea. I am hopeful that this will make analysis easier. I called it "encell" instead of "encage" to keep the use of "cell" consistent, even though "encage" is a word and "encell" isn't.
This makes things a little more complex to describe and adds a little more code. On the other hand, it saves a stack push and pop, and makes analysis simpler: it's impossible for PROTECT to refer to some random alien thunk. Also, hypothetically a VM impl could DX allocate the thunk even before analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various miscellaneous little changes in anticipation of doing some kinda release.